Dynamic notices fix for table detail page #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaalanwar
changed the title
Golodhros
requested review from
ttannis,
feng-tao,
allisonsuarez,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dkunitsk,
dechoma,
kristenarmes,
ozandogrultan,
B-T-D and
Golodhros
as code owners
|
Please rebase with master to fix the checks! |
mikaalanwar
force-pushed
the
dynamic-notices-fix
branch
from
9e5328b
to
1067b76
Compare
mikaalanwar
requested review from
jinhyukchang and
bolkedebruin
as code owners
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
…mundsen-io#2204 and amundsen-io#2205 Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
This reverts commit 58404fb. Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
This reverts commit fd130f7. Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
This reverts commit efece4c. Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
mikaalanwar
force-pushed
the
dynamic-notices-fix
branch
from
afe655d
to
6f24903
Compare
ozandogrultan
approved these changes
Nov 16, 2023
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix - This PR fixes the following issues in Amundsen:
Description
This PR updates the table detail page to initiate a new request for the Notice API every time we transition over from the "TableDetailPage" over to the "TableDetailPage" for a different table. Furthermore, it makes use of the
isLoadingNoticesflag to hide stale / previously loaded values from the component while a new one is being fetched via the Notice API.Motivation and Context
Issue # 2204 and Issue # 2205 prevented us from using a critical feature and depreciated the overall user experience of our users. This change helps address those issues.
How Has This Been Tested?
This has been tested locally as well as on the staging environment.
Documentation
The documentation did not require any further changes, beyond what's already mentioned.
CheckList