Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic notices fix for table detail page #2210

Merged
merged 23 commits into from
Nov 16, 2023
Merged

Dynamic notices fix for table detail page #2210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
13ff0b6
Bump: Amundsen-search version
MrwanBaghdad Oct 4, 2023
c235ece
remove BagelCode from README.md (#2197)
Xiroo Oct 5, 2023
2ea0974
DCAT-1397 Dynamic notices fix for table detail page resolving issue #…
mikaalanwar Nov 14, 2023
68de642
Version bump
mikaalanwar Nov 14, 2023
dad205a
Removing log statement used for debugging
mikaalanwar Nov 14, 2023
1c92c8c
Formatting fixes
mikaalanwar Nov 14, 2023
edac6bb
Formatting fixes
mikaalanwar Nov 14, 2023
d122b58
Formatting fixes
mikaalanwar Nov 14, 2023
585276b
Formatting fixes
mikaalanwar Nov 14, 2023
3d7d5c0
Formatting fix
mikaalanwar Nov 15, 2023
1ed99d2
Using destructuring operator
mikaalanwar Nov 15, 2023
0062b4b
Revert "Using destructuring operator"
mikaalanwar Nov 15, 2023
e50bcd2
Fixing unit tests
mikaalanwar Nov 15, 2023
6552f47
Using destructuring
mikaalanwar Nov 15, 2023
c2a3f60
Formatting fix
mikaalanwar Nov 15, 2023
933e8fa
Adding suppression for prettier
mikaalanwar Nov 15, 2023
7479ceb
Minor fix
mikaalanwar Nov 15, 2023
112059b
Minor fix
mikaalanwar Nov 15, 2023
6858b18
Formatting fixes
mikaalanwar Nov 15, 2023
519f21d
Minor fix
mikaalanwar Nov 15, 2023
4404e11
Refactoring
mikaalanwar Nov 15, 2023
4838963
Revert "Bump: Amundsen-search version"
mikaalanwar Nov 16, 2023
6f24903
Revert "remove BagelCode from README.md (#2197)"
mikaalanwar Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions frontend/amundsen_application/static/js/pages/TableDetailPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ export class TableDetail extends React.Component<
const {
location,
getTableData,
getNoticesDispatch,
getTableLineageDispatch,
match: { params },
} = this.props;
Expand All @@ -265,6 +266,10 @@ export class TableDetail extends React.Component<
this.key = newKey;
getTableData(this.key, index, source);

if (getDynamicNoticesEnabledByResource(ResourceType.table)) {
getNoticesDispatch(this.key);
}

if (isTableListLineageEnabled()) {
getTableLineageDispatch(this.key, defaultDepth);
}
Expand Down Expand Up @@ -672,7 +677,8 @@ export class TableDetail extends React.Component<
}

render() {
const { isLoading, statusCode, tableData, notices } = this.props;
const { isLoading, isLoadingNotices, notices, statusCode, tableData } =
this.props;
const { sortedBy, currentTab, isRightPanelOpen, selectedColumnDetails } =
this.state;
let innerContent: React.ReactNode;
Expand Down Expand Up @@ -749,7 +755,9 @@ export class TableDetail extends React.Component<
</header>
<div className="single-column-layout">
<aside className="left-panel">
<AlertList notices={aggregatedTableNotices} />
{!isLoadingNotices && (
<AlertList notices={aggregatedTableNotices} />
)}
<EditableSection
title={Constants.DESCRIPTION_TITLE}
readOnly={!data.is_editable}
Expand Down
2 changes: 1 addition & 1 deletion frontend/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def build_js() -> None:
with open(requirements_path) as requirements_file:
requirements_dev = requirements_file.readlines()

__version__ = '4.2.0'
__version__ = '4.2.1'

jira = ['jira==3.0.1']
asana = ['asana==0.10.3']
Expand Down
2 changes: 1 addition & 1 deletion frontend/tests/unit/api/metadata/test_v0.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from http import HTTPStatus

from amundsen_application import create_app
from amundsen_application.api.metadata.v0 import TABLE_ENDPOINT, TYPE_METADATA_ENDPOINT, LAST_INDEXED_ENDPOINT,\
from amundsen_application.api.metadata.v0 import TABLE_ENDPOINT, TYPE_METADATA_ENDPOINT, LAST_INDEXED_ENDPOINT, \
POPULAR_RESOURCES_ENDPOINT, TAGS_ENDPOINT, USER_ENDPOINT, DASHBOARD_ENDPOINT, FEATURE_ENDPOINT
from amundsen_application.config import MatchRuleObject

Expand Down
Loading