Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the wiki's CMakeLists.txt template #113

Open
douglaslassance opened this issue Nov 13, 2021 · 1 comment
Open

Update the wiki's CMakeLists.txt template #113

douglaslassance opened this issue Nov 13, 2021 · 1 comment

Comments

@douglaslassance
Copy link

I don't think you can submit GitHub wiki changes so I guess that's the best alternative.
The CMakeLists.txt template provided in the wiki ends with:

halleyProject(project_name "${SOURCES}" "${HEADERS}" "" ${CMAKE_CURRENT_SOURCE_DIR}/bin)

This actually results in building with the following error:

[build] [1/1   0% :: 0.000] Re-running CMake...
[build] CMake Error at CMakeLists.txt:25 (halleyProject):
[build]   halleyProject Function invoked with incorrect arguments for function named:
[build]   halleyProject
[build] 
[build] 
[build] -- Configuring incomplete, errors occurred!
[build] See also "/Users/douglaslassance/Desktop/WIP/halleygame/build/CMakeFiles/CMakeOutput.log".
[build] See also "/Users/douglaslassance/Desktop/WIP/halleygame/build/CMakeFiles/CMakeError.log".
[build] ninja: error: rebuilding 'build.ninja': subcommand failed
[build] FAILED: build.ninja 

The template should feature the missing argument as such:

halleyProject(project_name "${SOURCES}" "${HEADERS}" "" "" ${CMAKE_CURRENT_SOURCE_DIR}/bin)
@douglaslassance
Copy link
Author

douglaslassance commented Nov 14, 2021

After realizing there is a template folder, I'm thinking it's probably better to remove the hardcoded CMakeLists.txt template from the wiki and mention the folder. That said the template is also missing the argument proj_sources argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant