Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark improvements #6

Open
mranney opened this issue Dec 3, 2013 · 2 comments
Open

benchmark improvements #6

mranney opened this issue Dec 3, 2013 · 2 comments

Comments

@mranney
Copy link

mranney commented Dec 3, 2013

There is a lot of funny business with benchmarking node programs due to V8's very clever GC and recompilation behavior. To work around this, I suggest running each test several times so that the total runtime ends up being around a minute per type of test. Varying the order might also yield different results.

An added benefit of smoothing out the variance by running longer is that you can capture some stacks with DTrace and see where the time is actually going.

@anandsuresh
Copy link
Owner

Sounds good to me. Hopefully I should be able to get that done over the upcoming weekend.

On Dec 2, 2013, at 6:20 PM, Matt Ranney [email protected] wrote:

benefit of smoothing out the variance by running longer is that you can capture some stacks with DTrace and see where the time is actually going

@anandsuresh
Copy link
Owner

For a start, I’ve modified the code to use buffers instead of strings. That little change has made quite a bit of difference in the GC interference. Running the benchmarks with —trace_gc reveals that it barely runs the GC during the benchmarks.

I do like the idea of running vFlame and dTrace to get more insights into where its spending the most time.

On Dec 2, 2013, at 6:21 PM, Anand Suresh [email protected] wrote:

Sounds good to me. Hopefully I should be able to get that done over the upcoming weekend.

On Dec 2, 2013, at 6:20 PM, Matt Ranney [email protected] wrote:

benefit of smoothing out the variance by running longer is that you can capture some stacks with DTrace and see where the time is actually going

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants