Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform modules #2402

Open
noqcks opened this issue Dec 7, 2023 · 4 comments
Open

terraform modules #2402

noqcks opened this issue Dec 7, 2023 · 4 comments
Labels
enhancement New feature or request new-cataloger

Comments

@noqcks
Copy link
Contributor

noqcks commented Dec 7, 2023

What would you like to be added:

terraform modules and providers included in the SBOM components list

Why is this needed:

Would be nice to have terraform modules included in an SBOM, since they're technically 3rd party software that is used to build an application.

Additional context:

Checkcov has done a little work on this in the past
https://bridgecrew.io/blog/hacktoberfest-iac-software-bill-of-materials-checkov-cyclonedx/

@noqcks noqcks added the enhancement New feature or request label Dec 7, 2023
@willmurphyscode willmurphyscode moved this to Backlog in OSS Dec 11, 2023
@ghouscht
Copy link
Contributor

ghouscht commented Oct 24, 2024

Hey,
I saw a discussion on reddit (https://www.reddit.com/r/Terraform/comments/1g9go7p/what_do_you_use_to_generate_sbom_for_terraform/) and I'd like to look into this topic. I already have a working PoC for providers 🙂

However, tracking module dependencies might be a bit tricker as they don't seem to be tracked by the terraform lock file. See https://developer.hashicorp.com/terraform/language/files/dependency-lock#dependency-lock-file

At present, the dependency lock file tracks only provider dependencies. Terraform does not remember version selections for remote modules, and so Terraform will always select the newest available module version that meets the specified version constraints. You can use an exact version constraint to ensure that Terraform will always select the same module version.

@spiffcs
Copy link
Contributor

spiffcs commented Jan 23, 2025

I think we can close this now that #3378 has been closed and released.

If there are additional upgrades to that feature we want in the future we can reopen this or build a new issue that links to it.

@spiffcs spiffcs closed this as completed Jan 23, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in OSS Jan 23, 2025
@antonbabenko
Copy link

@spiffcs I think #3378 only takes care of Terraform providers, not Terraform modules. Let's keep this issue open.

@spiffcs
Copy link
Contributor

spiffcs commented Jan 23, 2025

@antonbabenko -- reading comprehension fail when I was going over staler issue this morning thanks for the catch here

@spiffcs spiffcs reopened this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new-cataloger
Projects
Status: Done
Development

No branches or pull requests

5 participants