From dc848ee8c7457b5804cd1874a3c9daca7e93840a Mon Sep 17 00:00:00 2001 From: Alex Woznyuk Date: Sat, 13 Apr 2024 09:06:40 +0000 Subject: [PATCH] sdk: remove unneeded begin/endTransaction while sdcard_init/uninit (#99) --- sdk/lib/lilka/src/lilka/fileutils.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sdk/lib/lilka/src/lilka/fileutils.cpp b/sdk/lib/lilka/src/lilka/fileutils.cpp index 952e8857..06124d19 100644 --- a/sdk/lib/lilka/src/lilka/fileutils.cpp +++ b/sdk/lib/lilka/src/lilka/fileutils.cpp @@ -241,9 +241,8 @@ bool FileUtils::createSDPartTable() { std::unique_ptr workbufPtr(workbuf); // init without mount - SPI1.beginTransaction(SPISettings(LILKA_SD_FREQUENCY, MSBFIRST, SPI_MODE0)); uint8_t pdrv = sdcard_init(LILKA_SDCARD_CS, &SPI1, LILKA_SD_FREQUENCY); - SPI1.endTransaction(); + if (pdrv == 0xFF) { xSemaphoreGive(sdMutex); return false; @@ -252,9 +251,7 @@ bool FileUtils::createSDPartTable() { // SD card uninitializer (RAII) std::unique_ptr sdcardUninit(nullptr, [](void* pdrv) { // C++ is beautiful and ugly at the same time - SPI1.beginTransaction(SPISettings(LILKA_SD_FREQUENCY, MSBFIRST, SPI_MODE0)); sdcard_uninit(*static_cast(pdrv)); - SPI1.endTransaction(); }); // Create partition table