Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (YT) : Overlay Button that opens up Captions Menu. #47

Closed
4 tasks done
Aryan-Chauhan opened this issue Mar 15, 2024 · 7 comments
Closed
4 tasks done

feat (YT) : Overlay Button that opens up Captions Menu. #47

Aryan-Chauhan opened this issue Mar 15, 2024 · 7 comments

Comments

@Aryan-Chauhan
Copy link

Aryan-Chauhan commented Mar 15, 2024

Application

YouTube

Feature description

Please add an overlay button that, when clicked, opens up Captions Menu.
Screenshot_2024-03-15-08-11-30-72_f22faf49515899f9781ec174a4d85388

Motivation

• Captions Menu has equal importance to that of Playback Speed Menu, but only the latter has a dedicated overlay button (as of yet).

• It will save steps/taps for opening Captions Menu. Saving steps/taps was also the motivation behind Playback Speed Overlay Button, so Captions Menu should also get equal treatment.

• If implemented, large number of people will use it, just like they use Playback Speed Overlay Button.

• I've personally seen multiple positive comments on how convenient Playback Speed Overlay Button is, and the proposed button is also a convenient & practical one. So, that's why it should be implemented.

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@anddea
Copy link
Owner

anddea commented Mar 15, 2024

Creating that many Overlay buttons takes a lot of space which is going to be user unfriendly.

Go to Settings > ReVanced > Player > Hide captions button (turn off that option). Captions button will appear at the top right corner of the player. You can tap to show/hide captions, and tap and hold to open the language selection menu.

@anddea anddea closed this as completed Mar 15, 2024
@Aryan-Chauhan
Copy link
Author

Aryan-Chauhan commented Mar 15, 2024

Creating that many Overlay buttons takes a lot of space which is going to be user unfriendly.

Go to Settings > ReVanced > Player > Hide captions button (turn off that option). Captions button will appear at the top right corner of the player. You can tap to show/hide captions, and tap and hold to open the language selection menu.

6 overlay buttons can easily be occupied on my Samsung Galaxy M31 (default font size, default screen zoom, default minimum width/smallest width). I'm going to use these 6:

  1. Playback Speed (available)
  2. Download (available)
  3. Captions ( feat (YT) : Overlay Button that opens up Captions Menu. #47 )
  4. Quality ( feat (YT) : Overlay Button that opens up Quality Menu. #49 )
  5. Share ( feat (YT) : Overlay Button that opens up Android's Native Share Menu. #50 )
  6. Save To Playlist ( feat (YT) : Overlay Button that opens up Save To Playlist Menu. #51 )

I genuinely believe that 5 or 6 overlay buttons will be user friendly, and even if they aren't, users can just enable/disable these buttons according to their preference.

Also, the reason for not using the default captions button in video player is, because it doesn't look symmetrical with reference to collapse button. Besides, the overlay button row will be a better placement for Captions button.

So, please re-open this issue for the following reason:

Users have the autonomy of enabling/disabling overlay buttons according to their preference and adding a Captions Overlay Button merely provides them a new choice, hence this request shouldn't be considered a user-unfriendly one.

@MondayNitro
Copy link
Contributor

Creating that many Overlay buttons takes a lot of space which is going to be user unfriendly.
Go to Settings > ReVanced > Player > Hide captions button (turn off that option). Captions button will appear at the top right corner of the player. You can tap to show/hide captions, and tap and hold to open the language selection menu.

6 overlay buttons can easily be occupied on my Samsung Galaxy M31 (default font size, default screen zoom, default minimum width/smallest width). I'm going to use these 6:

  1. Playback Speed (available)
  2. Download (available)
  3. Captions ( feat (YT) : Overlay Button that opens up Captions Menu. #47 )
  4. Quality ( feat (YT) : Overlay Button that opens up Quality Menu. #49 )
  5. Share ( feat (YT) : Overlay Button that opens up Android's Native Share Menu. #50 )
  6. Save To Playlist ( feat (YT) : Overlay Button that opens up Save To Playlist Menu. #51 )

I genuinely believe that 5 or 6 overlay buttons will be user friendly, and even if they aren't, users can just enable/disable these buttons according to their preference.

Also, the reason for not using the default captions button in video player is, because it doesn't look symmetrical with reference to collapse button.

So, please re-open this issue for the following reason:

Users have the autonomy of enabling/disabling overlay buttons according to their preference and adding a Captions Overlay Button merely provides them a new choice, hence this request shouldn't be considered a user-unfriendly one.

wdym by "doesnt look symmetrical"

@Aryan-Chauhan
Copy link
Author

Aryan-Chauhan commented Mar 15, 2024

Creating that many Overlay buttons takes a lot of space which is going to be user unfriendly.
Go to Settings > ReVanced > Player > Hide captions button (turn off that option). Captions button will appear at the top right corner of the player. You can tap to show/hide captions, and tap and hold to open the language selection menu.

6 overlay buttons can easily be occupied on my Samsung Galaxy M31 (default font size, default screen zoom, default minimum width/smallest width). I'm going to use these 6:

  1. Playback Speed (available)
  2. Download (available)
  3. Captions ( feat (YT) : Overlay Button that opens up Captions Menu. #47 )
  4. Quality ( feat (YT) : Overlay Button that opens up Quality Menu. #49 )
  5. Share ( feat (YT) : Overlay Button that opens up Android's Native Share Menu. #50 )
  6. Save To Playlist ( feat (YT) : Overlay Button that opens up Save To Playlist Menu. #51 )

I genuinely believe that 5 or 6 overlay buttons will be user friendly, and even if they aren't, users can just enable/disable these buttons according to their preference.

Also, the reason for not using the default captions button in video player is, because it doesn't look symmetrical with reference to collapse button.

So, please re-open this issue for the following reason:

Users have the autonomy of enabling/disabling overlay buttons according to their preference and adding a Captions Overlay Button merely provides them a new choice, hence this request shouldn't be considered a user-unfriendly one.

wdym by "doesnt look symmetrical"

I meant this. There should be 1 button on the top-left corner & 1 button on the top-right corner.

Even if you ignore that point, rest of the points still stands. It was anyways the weakest reason/argument of them all.
Screenshot_2024-03-15-14-04-49-77_f22faf49515899f9781ec174a4d85388.jpg

@MondayNitro
Copy link
Contributor

you mean stroke thickness of the captions button? i submitted a request for the same

@Aryan-Chauhan
Copy link
Author

Aryan-Chauhan commented Mar 15, 2024

you mean stroke thickness of the captions button? i submitted a request for the same

Nope. I simply meant that there should be 1 button on the top-left corner & 1 button on the top-right corner.

Although unrelated, your #56 is a reasonable request.

@Aryan-Chauhan
Copy link
Author

Closing this issue, because I listed all my YT feature requests in this single issue:

#225

anddea pushed a commit that referenced this issue May 16, 2024
* feat(YT Music): Clarify in-app strings

* clarify explanation

* fix(YT Music/Flyout menu components): Ambiguity in setting description

* feat(YT Music): Clarify setting descriptions

* feat(YouTube): Improve in-app string clarity

* feat(YouTube): Use arrows to describe settings paths

* Update strings.xml

Looks good

Co-authored-by: KobeW50 <[email protected]>

* Update strings.xml

Co-authored-by: KobeW50 <[email protected]>

* Update strings.xml

Co-authored-by: KobeW50 <[email protected]>

* Update strings.xml

* Update strings.xml (Clarify download button setting)

---------

Co-authored-by: inotia00 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants