Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT-145462: cpan(1) log message uses the wrong key #167

Open
briandfoy opened this issue Dec 7, 2022 · 1 comment
Open

RT-145462: cpan(1) log message uses the wrong key #167

briandfoy opened this issue Dec 7, 2022 · 1 comment

Comments

@briandfoy
Copy link
Contributor

I'm transferring and splitting up some issues reported in App::Cpan many problems, multiple fixes.

In App::Cpan::_download, the log line uses the wrong variable as a hash key:

$logger->info( "Downloaded [$arg] to [$paths{$arg}]" );

It should be:

$logger->info( "Downloaded [$arg] to [$paths{$module}]" );

This is related to #162 with some rearranging that needs to happen for track errors and return the appropriate values.

Patch provided by "eponymous alias" [email protected] in the RT ticket
App.Cpan.patch.txt

briandfoy added a commit to briandfoy/cpanpm that referenced this issue Dec 8, 2022
@x-yuri
Copy link

x-yuri commented Apr 3, 2023

Indeed, right now cpan -g exits with an error (although the operation succeeds). The issue seemed to be fixed, but soon broken again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants