Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning in yamls and sources #8

Open
benjaminmenetrier opened this issue Nov 22, 2021 · 3 comments
Open

Cleaning in yamls and sources #8

benjaminmenetrier opened this issue Nov 22, 2021 · 3 comments
Assignees

Comments

@benjaminmenetrier
Copy link
Collaborator

I think some cleaning might be required in yamls: there are a lot of redundancies, for instance the variables in https://github.com/andreapiacentini/aq/blob/Feature/ChangeVar/test/testinput/dirac_loc_4d.yaml.

And also in the source. I saw that the QG model renamed:

  • ObsAuxControl into ObsBias
  • other ObsAux[...] into ObsBias[...]

I think it would be useful to stay close to the QG model in order to make updates easier.

@andreapiacentini
Copy link
Owner

Thanks Ben,
I'll have a look to the yamls redundancies. Some of the 4d yamls are generated by a python script that is not very keen in using mnemonic shorcuts.

Emanuele is our "Obs" routines master. I'll let him modify at best the ObsAux routines (yet ObsAux is the naming used in oops, isn't it?) toward the corresponding Qg choice, even if all the ObsBias treatments are probably not of immediate interest for AQ.

The updates are an open issue for us: what's the workflow to stay in phase with the fast evolving oops develop branch?
Time has come for a new brainstorming on localisations and on these workflow choices. Will you be around in a relatively near future?

@andreapiacentini andreapiacentini self-assigned this Nov 22, 2021
@benjaminmenetrier
Copy link
Collaborator Author

You are right, they are called ObsAux in the generic part of OOPS, so we might as well keep them that way in AQ. My agenda is open this week: we can talk any time except tomorrow (Tuesday).

andreapiacentini added a commit that referenced this issue Nov 22, 2021
Fix the output of the 4densvar (detected wrong obserror specification)
This commit refers to issue #8
@andreapiacentini andreapiacentini removed their assignment Nov 22, 2021
@andreapiacentini
Copy link
Owner

I modified the yamls and spotted a wrong obs error specification in NO_2. The reference changes as well.
Even if we decide to keep the ObsAux naming conventions, I'd like if Emanuele could go through it, clean some misporting (e.g. the hardwired ntypes=4) and add some warning print statement (or ABORT) if anything were calling them since we did not really tested it.
Suggested new meeting on Thursday at 3PM CET

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants