-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roms with (World) are being preferred, even if they are clonesof. #43
Comments
World means USA+EUR+JPN. It therefore doesn't discriminate between them. USA and World are both "USA". You can maybe get it to avoid Collection ROMs by using |
Hi, the exact same thing happened to me. |
For whatever reason I didn't see your comment here. Sorry for taking so long to get back to you. I kinda get where you're coming from, but it's a little weird if you think about it. I may be understanding it wrong. Let me know if I am. World usually just means that a game has probably little text (and the little is there is in English), or that it is thoroughly localized in the first place, so it gets released, unmodified, across all major regions. Those games might even have a (USA) variant or something, but I have no idea why those would be preferred. I can add a specific option for such thing (for those who aren't so fond of using |
Hi! Let me give you an example with nes game Super C (USA), Super Contra (Japan), Probotector II (Europe). It turns out that the (World) released version of this game is Probotector II - Return of the Evil Forces (World) (Contra Anniversary Collection), which is the European (censored) version of the game. Therefore, for example when you do -r USA,EUR,JPN the program is indirectly prioritizing a European version over an American one. Ideally, the program should keep the American version Super C (USA) instead (World) version. I created a fork of your program with this very little modification and I also added an independent filter for the roms [b], if you are interested you can review it, I was testing it and I got the results I was looking for. I hope I was clear, as english is not my first language. Goodbye! |
Ok, that makes sense. Ok, I'll see if I can add an option for that. |
I used this command:
python3 generate.py -r USA,BRA,EUR -l en --no-bios --no-program --no-enhancement-chip --no-proto --no-beta --no-demo --no-sample --no-pirate --no-homebrew --no-promo -d snes.dat
In the result, the program is choosing the rom Darius Force (World) (Darius Cozmic Collection).zip, even though in the dat file it is marked as a clone of the rom Super Nova.
I manually checked the CRC of the roms and they match what is in the dat.
Since I specified the USA region, shouldn't it disregard the World rom?
snes.dat.zip
The text was updated successfully, but these errors were encountered: