-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate sample code from USAGE.md into samples collection #68
Comments
@bocops I had a look ad If I am not mistaken, our client always uses an access token at the end, which is set using |
I just saw your PR #88, probably makes sense to leave a note here in the context of those changes first. From personal experience with trying out the original library a month ago, getting the whole OAuth flow correctly was the trickiest part, and in hindsight two choices of the original README plus samples seem to be the main culprits:
In combination, I spent too much time on trying to get horribly wrong authentication flows to work, before reading up on OAuth elsewhere and finding out that it's actually not that hard to do right. ;) So my suggestions would be to:
|
Reviewing your PR #88 now, I see the use of placeholder strings throughout, like in
Would it perhaps be better to read these from the command line and comment the variables, so that library users can just compile and run to immediately see some first results? We could then even add the necessary commands to USAGE.md (replacing code samples) or any other file or Wiki page where it fits best. So, using the above example again:
In the case of samples that need authentication, if we want to keep Authenticator clases and their configuration file output, this could be two commands like:
|
As discussed here, the code in USAGE.md should be merged into our samples collection, currently available in the
sample
and thesample-kotlin
modules.Main tasks include:
The text was updated successfully, but these errors were encountered: