Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub Enterprise Server #511

Open
Wilhelmsson177 opened this issue Nov 10, 2022 · 4 comments
Open

Support GitHub Enterprise Server #511

Wilhelmsson177 opened this issue Nov 10, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@Wilhelmsson177
Copy link

Problem

I want to use nitpick with a style file located in a private repository on a GitHub Enterprise Server to have a consistent style of my settings within my organization.

Possible solution

Currently, the GitHub URLs are hard coded in nitpick GitHub Fetcher implementation. The idea is to set an environment variable with the GitHub Enterprise Server URL or extend the URL of the remote style with the URL of the GitHub Enterprise Serer URL.

I tried to just set the URL in

GITHUB_COM = "github.com"
on my local installation, but that did not solve my issue. I'm not familiar with the entire URL validation process and did not want to dig to deep into this issue.

For more information, see the CONTRIBUTING guide.

@Wilhelmsson177 Wilhelmsson177 added the enhancement New feature or request label Nov 10, 2022
@andreoliwa
Copy link
Owner

👋🏻 Hello, and thanks for the request.

I don't have access to any GitHub Enterprise Server.
My idea to test this (when I have time):

  1. Replace the URL as you did.
  2. See what breaks, and fix the code to make it work.
  3. Give you the branch so you can test it on your server and let me know.

Any other ideas?

@andreoliwa andreoliwa moved this to In progress in Nitpick Roadmap Nov 11, 2022
@andreoliwa andreoliwa moved this from In progress to Upvoted / Requests in Nitpick Roadmap Nov 11, 2022
@Wilhelmsson177
Copy link
Author

Hello @andreoliwa

sounds like a plan. I can assist on testing the new feature.

@Wilhelmsson177
Copy link
Author

Hello @andreoliwa,

did you already have a chance to take a look at the issue?

@andreoliwa
Copy link
Owner

Didn't have time yet... 😐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Upvoted / Requests
Development

No branches or pull requests

2 participants