Stop passing filenames to nitpick-check @ pre-commit hooks
#673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default is `pass_filenames: true`. This was causing the checks to be skipped even with `pre-commit run --all-files`. The hook was returning successful validation while there were multiple violations. Signed-off-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
andreoliwa
reviewed
Aug 12, 2024
| @@ -27,3 +27,4 @@ | |||
| description: "Only check configuration files (TOML/INI/JSON/etc.) and print the violations, according to the Nitpick style" | |||
| entry: nitpick check | |||
| language: python | |||
| pass_filenames: false | |||
There was a problem hiding this comment.
I had a similar problem before, I'm not sure if changing this line will bring the issue again.
- This was the previous fix removing
pass_filenames: fix: run pre-commit hooks only on passed files #356 - See this comment: "No Python file was found on the root dir and subdir" with submodule #354 (comment)
- And also this comment from the creator of pre-commit himself:
and nitpick run unconditionally checks every file always. they've sidestepped the framework and you should open an issue asking them to change to linting filenames which are passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is
pass_filenames: true. This was causing the checks to be skipped even withpre-commit run --all-files. The hook was returning successful validation while there were multiple violations.