Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSL connection timeout doesn't work #7989

Closed
andresriancho opened this issue Feb 3, 2015 · 1 comment
Closed

SSL connection timeout doesn't work #7989

andresriancho opened this issue Feb 3, 2015 · 1 comment
Labels
bug priority:low

Comments

@andresriancho
Copy link
Owner

A bug in the pyopenssl doesn't allow me to set the socket's timeout. The bug is explained in detail here: pyca/pyopenssl#168

This doesn't allow w3af to have connection timeouts for slow/unresponsive/idle SSL connections.

The issue was discovered while I was working on the SSL SNI support at #5802

This issue is just a reminder to self, I should check every N months to see if the guys at pyopenssl fixed the issue or not. AFAIK there is nothing I can do to fix this in the w3af repo.
@andresriancho andresriancho mentioned this issue Feb 3, 2015
Closed
andresriancho added a commit that referenced this issue Feb 4, 2015
@andresriancho
Skipping until #7989 is fixed
ad5e57a
@andresriancho andresriancho modified the milestone: Undefined Feb 5, 2015
andresriancho added a commit that referenced this issue Mar 9, 2015
@andresriancho
Disable timeout for #7989
dfe4dd3
@andresriancho andresriancho mentioned this issue Mar 13, 2015
Closed
andresriancho added a commit that referenced this issue Mar 13, 2015
@andresriancho
Adding test related with SSL connection timeout doesn't work #7989
1451451
andresriancho added a commit that referenced this issue Mar 13, 2015
@andresriancho
* Workaround for SSL connection timeout doesn't work #7989 in un_ssl
712f28e 
* Fix Scan using test_delay_moth.w3af hangs #8871
andresriancho added a commit that referenced this issue Mar 13, 2015
@andresriancho
* Improved connection handshake for #7989
4b6d4cd 
* There is a test (test_timeout_ssl) which is still failing, but I want to see how the whole suite reacts to this change
@andresriancho andresriancho modified the milestone: Undefined Jun 15, 2015
@andresriancho
Copy link
Owner Author

Code which uses select to wrap openssl at https://chromium.googlesource.com/infra/third_party/requests/+/7aa6c62d6d917e11f81b166d1d6c9e60340783ac/requests/packages/urllib3/contrib/pyopenssl.py

andresriancho added a commit that referenced this issue Jun 26, 2018
@andresriancho
Fixes SSL connection timeout doesn't work #7989
8583370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andresriancho