fix: properly detect application (tempestphp#456)

brendt · web-flow · commit ee84b94aa9b9 · 2024-09-22T06:56:32.000+02:00
diff --git a/src/Tempest/Core/src/GenericExceptionHandlerSetup.php b/src/Tempest/Core/src/GenericExceptionHandlerSetup.php
@@ -18,7 +18,7 @@ public function setup(AppConfig $appConfig): void
         }
 
         // Console
-        if ($_SERVER['argv'] ?? null) {
+        if (PHP_SAPI === 'cli') {
             (new Collision())->register();
 
             return;
diff --git a/src/Tempest/Framework/Application/ApplicationInitializer.php b/src/Tempest/Framework/Application/ApplicationInitializer.php
@@ -18,7 +18,7 @@
     #[Singleton]
     public function initialize(Container $container): Application
     {
-        if (isset($_SERVER['argv'])) {
+        if (PHP_SAPI === 'cli') {
             return new ConsoleApplication(
                 container: $container,
                 appConfig: $container->get(AppConfig::class),

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public function setup(AppConfig $appConfig): void`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`// Console`
`21`		`- if ($_SERVER['argv'] ?? null) {`
	`21`	`+ if (PHP_SAPI === 'cli') {`
`22`	`22`	`(new Collision())->register();`
`23`	`23`
`24`	`24`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`#[Singleton]`
`19`	`19`	`public function initialize(Container $container): Application`
`20`	`20`	`{`
`21`		`- if (isset($_SERVER['argv'])) {`
	`21`	`+ if (PHP_SAPI === 'cli') {`
`22`	`22`	`return new ConsoleApplication(`
`23`	`23`	`container: $container,`
`24`	`24`	`appConfig: $container->get(AppConfig::class),`