Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app sometimes crashes when I do "Stop all" #31

Open
gdubicki opened this issue Jan 12, 2024 · 5 comments
Open

The app sometimes crashes when I do "Stop all" #31

gdubicki opened this issue Jan 12, 2024 · 5 comments

Comments

@gdubicki
Copy link

Hi,

I am using macOS Sonoma (14.2.1 (23C71)) on an M1 Pro MacBook and the latest version of this app, installed today.

Firstly, thanks to all the contributors for it! It is very useful and exactly what I need.

Starting all the services for me works:

Screenshot 2024-01-12 at 16 27 41

But when I use "stop all", the app sometimes crashes without any error message.

I had this problem 2 or 3 times but when I am trying to reproduce it now, I can't... 😅 Good for me, I guess.

But still reporting it, maybe more people with this problem with show up and share some more helpful troubleshooting info.

@stefansundin
Copy link
Contributor

The problem is probably that you are activating the menu again too quickly, and because there is insufficient locking, you are making the app do conflicting actions at the same time. If you wait a moment before checking the menu again then I think it should be fine.

I was able to reproduce this crash so I updated my PR (#30) with a fix.

@stefansundin
Copy link
Contributor

I uploaded a build in the PR comments so feel free to test it out and let me know if it solves the crash for you. #30 (comment)

@stefansundin
Copy link
Contributor

I just realized that you have unbound in your list of services, so you may benefit from this PR that I just got merged into Homebrew: Homebrew/homebrew-services#625

@gdubicki
Copy link
Author

gdubicki commented Mar 6, 2024

Bit thanks @stefansundin! I updated Homebrew and switched to your test build mentioned above. I'll let you know in some time if I experience any more crashes.

@andrewn
Copy link
Owner

andrewn commented Mar 15, 2024

Sorry about the delay. I'll try and get a build out this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants