-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] From Cmake-3.31.0 some warnings " (cmake_minimum_required)" #2100
Comments
Thanks for the heads up. Changing that is a breaking change for any of our users that are still on 3.6, which was the first version we had in the Android SDK and our metrics say is still used by a a handful of users (1.5% ish). We'll hold off on changing this until CMake decides to follow through on the removal. I don't think I've been through a CMake deprecation before so I'm not sure if they follow through on removals or if they deprecate to cover their asses in the event that they've got an engineering reason to remove a thing later. 1% of builds isn't all that many, and the number of those that are using a modern NDK is probably much lower (unfortunately I don't have those stats correlated), so fixing this probably wouldn't be too disruptive, but I'd prefer not to break anyone at all to just fix a warning. |
This seems like an annoying issue when you have lot of useful logs along the build, found a workaround to suppress the warnings here.
|
Maybe you could add a "work-around" for that.
A little bit strange but it should work. Of course that would not help if you use deprecated API. But I don't think that there is any - otherwise it should be replaced soon with an IF(CMAKE_VERSION). |
I agree, it's just not as annoying as your build being broken, and the only way I can fix the warning is by breaking the build for people using older versions of CMake.
That would fork the behavior of the toolchain file and we'd have to test with multiple versions of CMake, which we don't currently have infrastucture for and I'd rather not add yet another dimension to our test matrix. |
The build would only get broken if people upgrade to a newer NDK version. Could it be okay to ask 1% of people to either use an older version of NDK or a newer version of CMake? |
That is the alternative. If this warning is truly so bothersome that you want those people broken then that's what has to happen, but I'd rather not break those users to fix a thing that's just annoying. Clearly this is going to happen eventually. Does it really have to happen now? It's just a warning. |
I would prefer to happen it now. It is not a single warning. It happens a lot of times in a single build and floods the log :/ |
For some unknown reason, the workaround(
|
Alright. I'll change it in r28, but if we get a bunch of conflicting feedback from people that are broken by it (I don't expect it, but it's impossible to know, and I prefer to err on the side of not breaking people), that may need to be reverted in a minor release. |
Description
On my side CMakeLists.txt updated and it's ok .
cmake_minimum_required(VERSION 2.8...3.10)
Affected versions
r27, r28
Canary version
No response
Host OS
Linux
Host OS version
Ubuntu 24.04.1
Affected ABIs
armeabi-v7a
Build system
CMake
Other build system
No response
minSdkVersion
Null
Device API level
No response
The text was updated successfully, but these errors were encountered: