User.Find impossible to use correctly

[Ntr0]

Describe the bug

I wanted to use an accounts key to find out the account id, by calling client.User.Find("ntr0") but I only got this
error getting user data for account id ntr0: The username query parameter was not provided: request failed. Please analyze the request body for more details. Status code: 400

Expected behavior

I get a list of users with matching usernames.

Possible Solution

I think the short solution would be to replace the "query" arg with the desired "username" arg.

go-jira/user.go

Line 238 in a1f44bd

name: "query",

It should also be possible to provide a User.GetByKey and User.GetByUsername methods would be really nice to have, since these would only return a single user with exact matching key or username.

Your Environment

• go-jira version v1.13.0
• Go version 1.16.5:
• Jira version: v8.16.1
• Jira type on-premise):
• Involved Jira plugins: unknown
• Operating System and version: Client runs on Linux

Additional context

[github-actions]

Hi! Thank you for taking the time to create your first issue! Really cool to see you here for the first time. Please give us a bit of time to review it.

[ArcticSnowman]

The problem is that Jira Cloud API accepts query=blah while Jira Server only accepts username=blah

[ArcticSnowman]

I used this to write my own request for this.

	req, _ := client.NewRequest("GET", fmt.Sprintf("/rest/api/2/user/search?username=%s", query), nil)

	users := []jira.User{}

	// users, _, err := client.User.Find(user.Profile.Email)
	_, err := client.Do(req, &users)
	if err != nil {
		log.Printf("%v", err)
		return nil, err
	}

[andygrunwald]

Hey,

I am very sorry that this issue has been open for a long time with no final solution. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489

The development will take some time; however, I hope you can benefit from the changes.
If you seek priority development for your issue + you like to sponsor it, please contact me.

What does this mean for my issue?

We will work on this issue indirectly.
This means that during the development phase, we aim to tackle it.
Maybe in a different way like it is currently handled.
Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using this library.
If there is anything else you would like to tell us, let us know!