Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand field from search isn't parsed #390

Open
leviska opened this issue Jul 26, 2021 · 3 comments
Open

Expand field from search isn't parsed #390

leviska opened this issue Jul 26, 2021 · 3 comments
Labels
needs triage Ticket that needs triage (a proper look for classification)

Comments

@leviska
Copy link

leviska commented Jul 26, 2021

Is your feature request related to a problem? Please describe.

You can add "expand" field to the search request
https://developer.atlassian.com/cloud/jira/platform/rest/v3/api-group-issue-search/#api-rest-api-3-search-get
https://pkg.go.dev/github.com/andygrunwald/go-jira?utm_source=godoc#SearchOptions
So if you add "names" or "schema" for example, you can't get them from the result, because library will read the body, and will not parse this fields

Describe the solution you'd like

Add this fields into searchResult and somehow return them from Search function

Describe alternatives you've considered

I can make the request myself, but it's strange, that you can add "expand" in request, but can't read the result

@github-actions
Copy link

Hi! Thank you for taking the time to create your first issue! Really cool to see you here for the first time. Please give us a bit of time to review it.

@leviska
Copy link
Author

leviska commented Jul 26, 2021

If you add expand: names, you'll have something like this in response:

{
    "expand": "schema,names",
    "startAt": 0,
    "maxResults": 50,
    "total": 7,
    "issues": [],
    "names": {}
}

And as you can see from searchResult, the "names" field isn't parsed

@andygrunwald andygrunwald added the needs triage Ticket that needs triage (a proper look for classification) label Aug 20, 2022
@andygrunwald
Copy link
Owner

Hey,

I am very sorry that this issue has been open for a long time with no final solution. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489

The development will take some time; however, I hope you can benefit from the changes.
If you seek priority development for your issue + you like to sponsor it, please contact me.

What does this mean for my issue?

We will work on this issue indirectly.
This means that during the development phase, we aim to tackle it.
Maybe in a different way like it is currently handled.
Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using this library.
If there is anything else you would like to tell us, let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Ticket that needs triage (a proper look for classification)
Projects
None yet
Development

No branches or pull requests

2 participants