Add command fails on windows

[wvdvegt]

When I try to add twig using

perseus add "twig/twig"

I get a warning

Failed to retrieve information about package "twig/twig" from Packagist. Called https://packagist.org/packages%5Ctwig%5Ctwig.json. Error: Expected a return code within 2xx for package "twig/twig". Got 404

It seems that the %5C escapes are not accepted by packagist anymore as

https://packagist.org/packages%5Ctwig%5Ctwig.json

returns the requested json

Expected Behavior

Should just work

Current Behavior

Fails to retrieve the package description.

Possible Solution

Steps to Reproduce (for bugs)

1. run perseus add "twig/twig" on windows.

Context

Your Environment

• Version used (perseus version):
• Operating System and version:
• Medusa configuration:
• Satis configuration:

[andygrunwald]

Hey @wvdvegt,
thanks for raising this issue. Indeed, I never tested it on windows.
Would you be open to testing it further, try to fix this one and send a Pull Request? This would help a lot.
Let me know what you think.

[wvdvegt]

Hi,

I do not have go installed nor have experience with it, but i might try if i have some spare time. Always ready to learn.

[andygrunwald]

Sounds great. Let me know how I can help or guide you a bit.

[wvdvegt]

I Installed GO and tried to follow your 'from source' installation script (on Windows). Some remarks:

1. $GOPATH needs to be replaced by %GOPATH% to work.
2. The path in the line
   cd "%GOPATH%/src/github.com/andygrunwald/perseus"
   needs to be quoted (note that Windows happily accepts \ and / in a path).
3. After some fiddling I got the 3rd line to work (added -v switch for some output)
4. This one fails, which 'make' is used?

[wvdvegt]

I mostly get

no Go files in C:\Users\xxx\go\src\github.com\andygrunwald\perseus

type of errors when I run go install.

[wvdvegt]

Hi
Got it running under Visual Studio Code.

In dependency/repository/packagist.go the lines:

// GetPackageByName returns a package by a given name
func (c *PackagistClient) GetPackageByName(name string) (*PackagistPackage, *http.Response, error) {
	u := fmt.Sprintf("%s/packages%s.json", c.url.String(), filepath.Clean("/"+name))

should be changed to:

// GetPackageByName returns a package by a given name
func (c *PackagistClient) GetPackageByName(name string) (*PackagistPackage, *http.Response, error) {
	u := fmt.Sprintf("%s/packages/%s.json", c.url.String(), name)

to at least get it downloading (not sure if it totally works).

The main issue is that filePath.Clean() method seems to replace all / and \ by the operating system's directory separator char (so the original /twig/twig gets changed into \twig\twig resulting in %5C escape codes in the url. Think it's caused by using a file path method on a url segment.

Something as

u := fmt.Sprintf("%s/packages%s.json", c.url.String(), strings.Replace(filepath.Clean("/"+name), "\\", "/", -1))

might also do the trick. It leaves the Clean() in place but flips the slashes back into url mode.

Maybe it needs to be changed on some more spots in the code.

[andygrunwald]

@wvdvegt Sounds reasonable. Thanks for the investigation so far.
Would you be open to create a Pull Request with the adjustments?

Thanks!

[wvdvegt]

Hi, I think i managed to create a pull request (not fluent in that part of git). Change is only one line in Packagist.go. The issue is caused by using the filepath.Clean() method that is meant for filenames and not for URLs (so it uses the operating systems path separator and not the / URL segment separator. Under Linux/OSX both are ‘/’ (so the error does not ‘occur’) but in Windows it’s a ‘\’ (although Windows accepts both ‘\’ and ‘/’ in filenames) causing it to be HTML encoded and Packagist to return 4XX responses. Best Wim van der Vegt From: Andy Grunwald Sent: zondag 27 september 2020 13:45 To: andygrunwald/perseus Cc: wvdvegt; Mention Subject: Re: [andygrunwald/perseus] Add command fails on windows (#6) @wvdvegt Sounds reasonable. Thanks for the investigation so far. Would you be open to create a Pull Request with the adjustments? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.