Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem to handle absent or duplicate filenames #10

Open
mdmbkr opened this issue Jun 4, 2021 · 1 comment
Open

Doesn't seem to handle absent or duplicate filenames #10

mdmbkr opened this issue Jun 4, 2021 · 1 comment

Comments

@mdmbkr
Copy link

mdmbkr commented Jun 4, 2021

Edit: I originally described this issue as "improper handling of duplicate filenames" but it also doesn't handle images with no filename. Somehow I have several galleries containing numerous images with no filename. When I download those galleries via SmugMug's web interface, the resulting zipfile contains images named .jpg, -1.jpg, -2.jpg etc.

I did an Extremely Crude Hack to add an incrementing number to every filename and it does allow the script to get past this problem. However, this also means that there's no file extension on images with a blank filename.

2nd edit: A separate but possibly related issue is that it's possible to have more than one gallery with the same name. Trying to use smdl to retrieve such a gallery leads to a crash. I thought there might be an issue with multiple identically named galleries, but it's really just the empty filename issue happening. However, there's no way to download just one of those multiple galleries - perhaps it would be possible to specify the "URL name" for the gallery, just like what's used for creating the image directories on disk?

@mdmbkr mdmbkr changed the title Doesn't seem to handle duplicate filenames Doesn't seem to handle absent or duplicate filenames Jun 7, 2021
@andyjsmith
Copy link
Owner

If you let me know an example user and album with empty filenames I can see what I can do to address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants