Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out deleted tasks when building review queue #237

Open
andymatuschak opened this issue Aug 19, 2021 · 0 comments
Open

Filter out deleted tasks when building review queue #237

andymatuschak opened this issue Aug 19, 2021 · 0 comments
Labels
🗂 Bug Type: Technical defect, not functioning as designed 🚩 Help wanted Particularly amenable/appropriate for contributors

Comments

@andymatuschak
Copy link
Owner

Our data store is architected such that tasks are never deleted; they're just flagged as deleted. When building a review queue (e.g. in app's databaseManager and backend's notification bits), we should exclude deleted tasks. Doesn't actually affect anyone but me yet, but will once we add a UI for deleting.

(Unfortunately, this'll probably muck up our indexing / predicate strategies a bit—we can't just add the isDeleted column to our composite indexes without mucking up order when not filtering by isDeleted)

@andymatuschak andymatuschak added 🗂 Bug Type: Technical defect, not functioning as designed 🚩 Help wanted Particularly amenable/appropriate for contributors labels Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗂 Bug Type: Technical defect, not functioning as designed 🚩 Help wanted Particularly amenable/appropriate for contributors
Projects
None yet
Development

No branches or pull requests

1 participant