From 778e16f43f11bcf4291b99b039935f47d4221bee Mon Sep 17 00:00:00 2001 From: Dennis Haney Date: Wed, 16 Aug 2023 11:54:26 +0700 Subject: [PATCH 1/2] Fix wrong defaults and defaults not matching stated defaults --- charts/README.md | 16 ++++++++-------- charts/latest/csi-driver-smb/values.yaml | 3 ++- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/charts/README.md b/charts/README.md index 5f55988b1b4..7ff6e53997e 100644 --- a/charts/README.md +++ b/charts/README.md @@ -71,7 +71,7 @@ The following table lists the configurable parameters of the latest SMB CSI Driv | `securityContext` | security context to be added to pods | `{ seccompProfile: {type: RuntimeDefault} }` | | `controller.name` | name of driver deployment | `csi-smb-controller` | | `controller.replicas` | replica num of csi-smb-controller | `1` | -| `controller.dnsPolicy` | dnsPolicy of driver node daemonset, available values: `Default`, `ClusterFirstWithHostNet`, `ClusterFirst` | `ClusterFirstWithHostNet` | +| `controller.dnsPolicy` | dnsPolicy of driver node daemonset, available values: `Default`, `ClusterFirstWithHostNet`, `ClusterFirst` | `ClusterFirstWithHostNet` | | `controller.metricsPort` | metrics port of csi-smb-controller | `29644` | | `controller.livenessProbe.healthPort ` | health check port for liveness probe | `29642` | | `controller.logLevel` | controller driver log level | `5` | @@ -100,7 +100,7 @@ The following table lists the configurable parameters of the latest SMB CSI Driv | `node.nodeSelector` | node pod node selector | `{}` | | `linux.enabled` | whether enable linux feature | `true` | | `linux.dsName` | name of driver daemonset on linux | `csi-smb-node` | -| `linux.dnsPolicy` | dnsPolicy of driver node daemonset, available values: `Default`, `ClusterFirstWithHostNet`, `ClusterFirst` | `ClusterFirstWithHostNet` | +| `linux.dnsPolicy` | dnsPolicy of driver node daemonset, available values: `Default`, `ClusterFirstWithHostNet`, `ClusterFirst` | `ClusterFirstWithHostNet` | | `linux.kubelet` | configure kubelet directory path on Linux agent node node | `/var/lib/kubelet` | | `linux.resources.livenessProbe.limits.memory` | liveness-probe memory limits | `100Mi` | | `linux.resources.livenessProbe.requests.cpu` | liveness-probe cpu requests limits | `10m` | @@ -135,12 +135,12 @@ The following table lists the configurable parameters of the latest CSI-proxy Dr |---------------------------------------------------------|------------------------------------------------------------------------------------------------------------|---------------------------------------------------------| | `windows.csiproxy.enabled` | whether enable csi-proxy daemonset | `false` | | `windows.csiproxy.dsName` | name of driver csi-proxy daemonset on windows | `csi-proxy-win` | -| `windows.csiproxy.username` | name of windows user on the host machine to run the proxy as | `NT AUTHORITY\\SYSTEM` | -| `windows.csiproxy.affinity` | controller pod affinity | `{}` | -| `windows.csiproxy.nodeSelector` | controller pod node selector | `{"kubernetes.io/os": windows}` | -| `windows.csiproxy.tolerations` | controller pod tolerations | `[]` | -| `image.csiproxy.repository` | csiproxy docker image | `ghcr.io/kubernetes-sigs/sig-windows/csi-provisioner` | -| `image.csiproxy.tag` | csiproxy docker image tag | `v1.1.2` | +| `windows.csiproxy.username` | name of windows user on the host machine to run the proxy as | `NT AUTHORITY\\SYSTEM` | +| `windows.csiproxy.affinity` | controller pod affinity | `{}` | +| `windows.csiproxy.nodeSelector` | controller pod node selector | `{"kubernetes.io/os": windows} | +| `windows.csiproxy.tolerations` | controller pod tolerations | `[]` | +| `image.csiproxy.repository` | csiproxy docker image | `ghcr.io/kubernetes-sigs/sig-windows/csi-proxy` | +| `image.csiproxy.tag` | csiproxy docker image tag | `v1.1.2` | | `image.csiproxy.pullPolicy` | csiproxy image pull policy | `IfNotPresent` | ## troubleshooting diff --git a/charts/latest/csi-driver-smb/values.yaml b/charts/latest/csi-driver-smb/values.yaml index 61d5ffbc5cf..c37a227124c 100755 --- a/charts/latest/csi-driver-smb/values.yaml +++ b/charts/latest/csi-driver-smb/values.yaml @@ -17,7 +17,7 @@ image: tag: v2.8.0 pullPolicy: IfNotPresent csiproxy: - repository: ghcr.io/kubernetes-sigs/sig-windows/csi-provisioner + repository: ghcr.io/kubernetes-sigs/sig-windows/csi-proxy tag: v1.1.2 pullPolicy: IfNotPresent @@ -147,6 +147,7 @@ windows: dsName: csi-proxy-win # daemonset name tolerations: {} affinity: {} + username: "NT AUTHORITY\\SYSTEM" nodeSelector: "kubernetes.io/os": windows From ca7d2abf1497838867ed5def4cd6d53f4db6b097 Mon Sep 17 00:00:00 2001 From: Dennis Haney Date: Wed, 16 Aug 2023 13:47:14 +0700 Subject: [PATCH 2/2] regen tgz file --- charts/latest/csi-driver-smb-v0.0.0.tgz | Bin 4751 -> 4788 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/charts/latest/csi-driver-smb-v0.0.0.tgz b/charts/latest/csi-driver-smb-v0.0.0.tgz index 8285433427249a3f161cb7a5874b0ebbd81c37b9..15686af84254dc456a8dc3b59238c061f90aba30 100644 GIT binary patch delta 4756 zcmV;F5^L>`CA1}wOn=*P9-S*7AKD}{Q_MCA;&c{+&7z>CW1F{k-c0`c1s{4- zw){xi?wUXwTO!XP56_F|khI5%<1;b`=J0UbKbv7DdJ7x|-|emp27|%L(UJN)7!0a^ z2L~s^?+%WRPF|n9J~=r)_-=4;G&nl?4h?qLhsKg{f!TM1t$%S<2ltH>9FyOHaY7>( z%?~;_jIQ+(1lS#9&Ie zV2j?TpLmbZK7S`uhYQN^6gmj;a4f4M#2}`e2+9^NntDvu{PYudxWH2qO`SrkJ`cxn zkW5LW8VWphk%uG97V3MP1i>{8h_`UjyU8UL*9+nF-HyznpKby78GrKK;y7`rj`KXb*Y^z2S1S9S&?xJb2@I zG>L@7?J>XtTqIZm=q3953?lXU6*6@Z)|EN>Oo9N7!8Gxefm+a{hejZfplE^v4v0+T zL-ZL(>VILvL4Ie5evWz)AB_Z~K>$n}Gaine{F%eCnWg-#A~(mK4jW^y+GSZ=8AfRh zJ9<*w;=`WDiJ8bwX98FxOmQ4UcpShlAbzJo62eGe!41exp^q7;dS5$g+5+NX?xKSZ zLVm34bJRr0s!=&S8R+K)h;dResSyCcGyF6#D07^7yh*-Gj;n7IL2m;3r2^Tzl0h0-M!bROnI`U@VCjoR@ z!8cM7OWt{MEY22aI!d=l8N&A;qD&UG0DqTxy@fy>wwSF>K%(S6S2=#BxO{$DQZ2G6 zdWn1tA&oc)rFouHuSjYKAY9a+W7ZGIxNn}=Sfp|7=vG8A8lt} zq7P93oGWXK0|wY%pc(chJ0ay8AQEwbg8=+j$iV5PZb#2RJ5_d{aMd%yz;ED7>3@0H zcr#;}AI{vnIc9eO8Q+E-9dDMa1>FYJ13oE?EC6Z5FjxF6jPsf zV(P!iYuUjB3dIr#_8=DO!-Px|Jrn(y`c7<6J23+YRm`j3iHrTwbIcc9 zK03Vw4Ir zULX!akZ6i9;s)HAh9)tL7k>!uaTo`HT=~6H#YGPi_8b0zOaJ*`FgQSu9ZMw+o=3y@ zn$Zc7?!|*x#NeWvBoZV9W0@b(<33{dA6zQ&KLKH^;=cXMtJ{lFPuz>`ajc5}A08c6 z;(y1-N3Zwszvn2oGf)Bj(fhY)P@ix#HTuVgIG_tq`dg`Aqw#v3&VMaM-VD4?)z(@; z3oH`;3dI3n4pJSt9pj04B0!EK4I7WK2d57YsCNUZUhgt}iXI;l{$9c5xh6 zd@Tv71_V7mc9G+J#=@KJ)z`ApDE}X45X8WEPsH1%0#?ZX!STsKMgC8Yjt=+o{~YDv zq5oGjC!s5S4kR4`>3;>BhLSAa3|#cr{^Mh(qpDrp$2jtpFC(Q+dU^7*r*g)s-ot}~ ze3+03P?v|}o~+hIPX0!^6sV`O%t}yuzw3;Xta&vD#)uE-Pw9C_9y&QxA4xb$CKGax zx=s!ZB42&hT{GV1gfcXPAk5cM$l5PmT?5mfrSn`@F3R7JJb&qf+fYGj zDy>E)Sl!gnIQtI|D3!t@5qpj8vIMKbrfK^o%j246k}5qu>#NBsRW*Zg@+WD_KUMHp zs^jkebW!(X*T9n0B$I6Fic1Qlh>ZmO1BZdV#-E5pK12cy75OzdIh)prjgugdo+<;O zr#Ew%8>Ut^7=P*dIkOacs}f$=f}v>if@3B60=6$fDdD7*8e1-?=m z^?zv@s}{x^Cxut&|HHxSivAxCjt&QV{r?=LA{|XJxW~sAolhk4U39L(86yxcI>o&s zIF5OLe(<6bg1|l&*nN@ZrKE5)!Pij}B;o7o%Ky`CY=3Uy3#nd6Hod!g$p&R2eKx{Z)oITu077pdQBz=zTu zHDQkwA&%oU2$YIv3NWX23#y!C-CZ9sLWY`>Up^BtYi?HvZWRy~LtZb6CL-_OPiA^k zwV5`phJP;dF&NxeaS9h@Wk$KUX4C_2Ql`b1S$O1fC4Z(-IP@p_S3-qanWUg*I!E!D zvQK3krKnsRniU(QOx}h-HOPud(@=mmz|WQ{$F`B$;J-giv54X z!RzCy|93n*-ur*gQ5?rf9Xl243n3CV$1eBlY;IkFNh0kuwDacLI&<2WlO9#-#1-8x z(0{wFN}HYRolD>A4)RjstmvIJIA_*jW;A=8()DI^J9%YwhstmI}C7si=mS@&cL!!P(VRd=S@o2jC)xNGKl zVeg8a{8@z@R(X?R%`qy!F2Kqmlry)>hJRmi4%Zp74!IX|!7fsJeVSOQC@c9cyaK%C zySH4_?N+&}nQyDeio5$-pe${*T8epdFScXtcx6RWWQ%H+wJwd-##WiENMsXhl-F98 zrPeykvX-Y_chsBw^lSrmJ7>MHC9~}D?!aSjgl+Yvi?xkUU3A`C`tCczS(a*qFn^mC zNUq7=b>^qTZtbBXCj$FE1I|ys|MAWF`OU>>^cPFT0I(0t0ke%`b&VEzJPQ!G7YsYv zXgjIFRJ**2l_8o}2dMeV450K5=^ceGl76fF*W=XtwC<{>Nd3~EyE8Q(JZRB?%5EW@d6Nj3jr9#CEAnGXB60ft zk7uKIA1^M?udm)+-r9_)Ir)+auR8VG8@P6~g>y1?%sM!e?Q$^?^wV@MGpcjaBosGuGVTy%SOy-7F9v@FGk?e$mcFP z9F*!9n~=ReD8G(@5$f9;H+o-1_P4uWNks15e!t0RE!CVcBXbhKw102}B`>Yi>Jxcr zmBwv_$%;UP@%H{7562DWNsr&MAhQk(!dNWSIk|_&T8ny5OVz)0@N!?aE-T~z#?owa zBfzTtzr$g5|L^OQeftx?;g62Iw$QVMyU45m8w|74k>N?v#?&q&}S5K~;=NL(KGK zdCYXjQPE`@BnM|3z8$Q^-7~}}9^bmV>&pM+pU20$J8cyC-Cg6#eMSF%`|$SSm&07k z$J{J?xqr_g?$%m9g*B?&i(RkK!d$I3Fsa|N)Hp0L@sE#pPhq(7v%eGW#3Tl%MuGyM zySv_toYouC`m(E!iMjy@CnV0Z-ZKvN~FiBinN0n#d}wxihxh5lgPaj@yvA3~MdE z+=$?Id`rCWWmuMLU9*DvnBK!(R>L}1a88&CS=R|~SNogyW-a7a+pskymMkTg_3nzD z>3_3ZU-1tNTBOC;R)Ko~2Y0QR;BmF0;QH;6C?jr^Qoc ze(RWY`ENKlx|2MwY|+V0WBX&HhVt8<7%k^p+osX=(as$v(TyAMEoZxH)X+2ZRiB*P zHXq(*Yx6!E{%xP$+A9K zl*arI8)MHgNuVdq{|pX~Ucav8e~$OR|MM)R7Md+zT&RRu$!PVUaCS0yRBEz38?@qH z#9gL_o}#~bRDPE|eRxRM5Y;4#lz+ixbD-YiM9e57|5mECer{X;VABl^VEIrLEMxi{ zxEFHq5ESq4Q&%vy9u!LgZKoaSef`2{5_1>*quc#wr{WO&qZ`ZdZ~>7p_T5yP0~@Of zQxM%(s2dQj{;HpKk{>i_#di?lNdUir_=5&X2xEZ-Hy}HOK4zfmeeI~p3y6ogi-sM9{D`Mi zKMxWvfc;7s7ylq){x{0SB?yF`BfP*Qkhqby3V$xTfGJJ_@uI0!`9%kz5CkJ0zotyM zX!PHw$H#Wbngb5RJg+9XgC)^b^bSjKuAZ^<;kh2!b$}ztUj=mbcUVB+qLU6npDFu9 zqS-si5Eq2GsM{A|+*PFDG+`cajoPMSWFJE!c=}BaBvg!lG#I=i<|%`JC%}ufyf|^u zaDNcinvK#{ma#V@8}5iKQ`OBVMmwRv(QQFf4sX1J*&G zVCkZ+k`+b+=;b;@YLrk-c-LU0v1~1&b>G|(E_nI^rc>~Qi@KL|?9IVX0_e7aZ=@oY zyz}T-oE^|~lx~qSgzr8?nJj7nF7tW|fqyz`FEOX1~Nf+Ri>lAEE#_ zSJoB>46wgMbL>lYLdwBFB;o=G0r)SFfzwN!kDh^crtCi9s%M0O-@upB|FH39#(y$D zox8US%x(iRxit@eQtS}Y1&rUleuv|jM6-*8k!bcI3YGtnO2SHgR#5_!Z>wN-V$GAS zCh>R|*4z>0^L4Hf_ONP*vH@{vbI_vz@0!d*;6@i8po80M9!Za z6-y#j2a^aG!W>03Vw4IrSt1TXkZ6W5;s)Hgh9)sgmI&@}7zcn{`MpxbMfVc+EB=8? z*LXM>4ADc!Qi+4-(J;Pdbbm^u=Ws8UF}Ua^i3AD37~Kc-a0to$c}pe!Cm@Vf+_!&u z_5RJcC+@`VIM&7gkB*Nj@xPOk(INi#B<1}aR6u|H?sXc}CmhX;dh#I-=n|BASK8Sq z#9pWKo+57!-luA7t-l2p34ej&05Aust=x|B!8{Ql$B{;m$Jm3j`+s}Xy8%_NcbPs# z4-c{r8kpm7V*t;(IF2h`mV{ITf*u~a$ZRUFnh_=_g1h;VhJ7@#f&7zxE#ZB7WKYJ=?tm@t0JAcTBDTx4ec{u6GYF*^yZ=}b8dOFLj1hw~v&N#`MR|{Z__<+7h zpF8r<>5=+K!f`U4k~`FOa$peo>a*^eaYm<$-ALo_^$k zi@G)yV{H@S2+zQGCd*2zu?bT*HPqo-*(8<1A`yFy?Xm=`!hfb|`zp)hnr4zJJwETN z$tqPfgK_dFY0EDvY%JAr_rJQR`>|_aNota5Hg&}n2U5gFg8mN<1AC1xh(ta_0*w^; zH8?q&)`^XiAdrqM1EHrk^Qar9RyG*x`Z=={daDv%*Lfw0w))IfjTnw*u(F+8{_9zj z#48TK{!w=4Yg`L_r8MgQ(gId3iMLJ)uhIWUgO?TkKN=hlP7nJ3DN02;nxbzH56?QE zNaVZdLIpC$Af9!Kdq;2_^ZsJ^tP_I3J{H)0mSv=*a5TZ!@e(BA>*~t?(`{^S;WLvz z2p4}?Ff3rURF4p1GzdsE`=H*LXZ2uvq3bHbSAK80jgVPb7eUGwso!eAhteH2QIQlO zj^hmol!|8xFsF43s+?xs-5fDOhMJOJJ`*u-ZdV9v6%ZDKUC)XpBJbZXW_nY#nKrFP zHu5nT+*ff57iDEmxwvN318$O~#g|$1ABKG*+Ni?QMZdDFmfpikw+8&<*UF8~MVd zI)wzcBHOdnw$CxYW}rO8ez$C~a~kLS7fNz~klq5LU7}LcbW03+c&NRzgLRwh2|Rz3 z?vo*Mz@cp~cEnVg&J59YVdF(JqHn3tk!bql5qV6vc6z)Ui{sz7Qf|bL?`z&gRw?m?Y9pLpyJ-tuv>6Iq6ZQPF&IL0=>_w zw9U!hx%9p6ATQxznEI+S0XVW%-@I|AL}| z!7srpELF>(3yHwIO(BQqS{D43W+gYHxG>Hf%ep617=FQ@sk$@G-b@vZ#a%Pc3%geA zZ0@B(s$nz&azY^gxRb>a!vNG zvp5@dYY!bc5!m+`aDMjV&#!+jE^gk8$A7U@3;_GU95A~)*4Jo}$Fl%|JHfD{jkc2- zOtrtOSQ(;4b%2_$%m7O7klst^BI&ove?3mUPn)iKiqtQyeF}gUY8STJS6rI_wO8yK zi@EMcrH5vxH}yV&aD2jw0f}tGmrY}o92irv(%pg<8IH;wuIi*xuNZ$||0)WWHT-&cWuK-<_ta9Zog?V2X+lX>mXq%W?*Hp9N2oeHK z#Mu$ARnVJ(otQFlX7_N)z0EfdmpiJVEzU+8$yFKlHe$6xaAawgx-G=2)Y~VKDjrVS zh>|qOdljG>z&aDlDqDXF%Qn!fg0Y^rQZL2EQFaUIESf~XY^iTBS&<)85{a`Pe?A|- z{rKkc;`-|C<$IeEHD_Kj;Z>(zdjr>wws1nmj#&q1vRy6)f_|DV3@y#f`4>kChZLHI zVOP${RDem9Q6pmJ^XcOSyJ?ivEb1Ensl1CB71X1Fi{77KZ_|H`GI_0-O_i3It$VR` znPL(o4BpQf@Hq{9eK;d8b0Om2prR@einZoyAb=X1?VViz5*%DWfR|(NXykJj9Sur# zj7`X156iD(V1)Yi#*N-rk^Sv1SQ3#tx8H9vS}QeY%*cWSFe@BB$xAD>`bZvHrEyzf zvLX;+yu1I$!%2UGdD7#zEXb?_gD@6Lbwcj`q1K|_(^B=X9lSi0oy*$zzp*sC+z7C4 z|Lo08D}!jm)tGNfEAKU>U^~5N%SolD z7w!9*wn~7l-5Rw^D)GBcD5a1$$zZAz|Bsd_ssxtv)ke#u+_`((w3yTP4yi@VAzuAd z@#;#DY;S)NYbCCom6qd)p-cE4JJi56snL8}9*;IMi7>oJYk3V1By#3?N&BvQJzkM8Eo&Wyv z`qlft{iR(r6YjKIRV*G2Lmc_l$Fd*Iw~qDT4lI8ScI$W!C8R!_*+Er|Nkh!^bal*h z&r#7;8YBm28@?T^#oaT+C?4Osz3s~X)Ef2hIKxf5(xYonAYEzciNsy7gdSZWqMbJnZLCv)+UqNryL8;L%FZ3eUG$x zi5q{{0V!7A!5UZyu+}CVGLT;{1F2n_mAS`lGJwq)%UVU*1LB|k_;XpPs})reR4#~} z83;$qj>82Oyx1#qZ(+}NX`y{|`raiKY6|tuOOCIuUUCwB_tKd~#jU)oX}28aMn2|t z*~>!?alh8`F|1MLUhH~>7UpWbfl2+AmBxQzg^7Q7xP1)6m7o2cawjG+I5iR!0Nvj9 zZe^w0LbEJ8TWwiKAtiqs9I{=d$#W#;z(I)vN0KAM2Q$Q-^;??N~qztvaTwWh0tvIBAJ%~yX? zcynx;%++?Ax+Pm=tJg50I^ZcgT~2Y8!T@#EPZls@`3(bA5K} z8@?jr|8;4V|K0KTAlBr6k4ClMe|Ud6IzHV0^dzN{h*F2c_L=?F01vreJ1rh7^IONH z%b(%k=w9-?vPCC1jqQ((8p`i_VziuZZJS2dM?3eJL^p20_nhsnQA5wrH+^z)*L--J zt<8sQ`1gH!YsXyp(`2i)tbNVXRfl}{x0dg=pGK}#+bug>XZWW`bz3TbGiiVBbz%LJ zHi7%Cj$ZGW*48>Ck2v&A#G&69aoFzs_kL5yTbx$iCUM-~Ds5a<%ZH@#A!)qvIoGDV zu@&k*6UT>y?)RI}U2h}4)nxAOE-6}lzV(TZt=7z{)yOa!;~Cb!{rsBvDr`?^gad0A zR2!u~Hag#0HAfpI3tMI`HurxbTBR*oOv3hE+^Po+bFed^vQ*c0-Kx1XhlI~JQ5y3< zY=S+aiJ1sC8O1Y!r95-ajD7bY|xr}5%-xI zdW`<&QTcuL^!`3wLsXL}QU+JefqIV2( za%MCyP&aNuw|-b2CsK1Z_Bx=Q0D6=%pF~BOu;EZr`#40i&b~