Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly manage cancellation token registering of logs in task creation (and anywhere else it is used) #1056

Open
aneojgurhem opened this issue May 4, 2023 · 1 comment
Open

Properly manage cancellation token registering of logs in task creation (and anywhere else it is used) #1056

aneojgurhem opened this issue May 4, 2023 · 1 comment
Labels
Core

Comments

@aneojgurhem
Copy link
Contributor 

          I think this could be problematic in a long running process as I think the cancellation token given to this function in always the same, so the register might be called multiple times on the same cancellation token. Should we unregister this callback at some point?

This should probably be done in another PR anyway.

Originally posted by @lemaitre-aneo in aneoconsulting/ArmoniK.Core#333 (comment)
@github-project-automation github-project-automation bot moved this to To do in ArmoniK May 4, 2023
@lemaitre-aneo
Copy link
Contributor

Maybe it is the cause of the "CPU Leak" #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core
Projects
ArmoniK
Status: To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aneojgurhem @lemaitre-aneo