Skip to content
This repository has been archived by the owner on Mar 22, 2021. It is now read-only.

mac_githash shell script causes Win32 exception on AppBuild from Windows #4

Open
TheTalisman opened this issue Jan 19, 2016 · 0 comments

Comments

@TheTalisman
Copy link

Not to be unexpected, of course, attempting to execute the bash script, "mac_githash.sh", described in the book will cause a Win32 exception when the AppBuilder's Build process is called when running Unity on Windows.

I suggest the following validation check (added to the GitHash() method in the Builder class):

private static string GitHash (  )
        {
            if (Application.platform == RuntimePlatform.OSXEditor) {
                string command = batchPath + "/mac_githash.sh";
                string output = ExecuteCommand (command);

                // We trim the output to remove new lines at the end.
                return output.Trim();
            }
            else {
                return "Not Implemented for Builds from Windows";
            }
        }
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant