Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular2 Nature #7

Open
angelozerr opened this issue Mar 12, 2016 · 2 comments
Open

Angular2 Nature #7

angelozerr opened this issue Mar 12, 2016 · 2 comments

Comments

@angelozerr
Copy link
Owner

How to determine that a project has Angular2 nature?

  • search in the package.json if angular2 exists as dependencies?
  • search from typing folder if angular2 exists?
  • search from node_modules if angular2 exists?

But those folder, package.json could be hosted not only in project root (like src folder). So we could foolw the same idea than angelozerr/typescript.java#12 (comment)

And at the end if the user project doesn't follow thoses rules, user will be able to to "Convert as Angular2" to add Eclipse Angular2 nature to the project.

What do you think about that @micaelgallego @piotrtomiak

@micaelgallego
Copy link

+1 To search in package.json. As far as I know, it is the common way to obtain angular2 dependencies.

If you search only in node_modules, what happen if npm install haven't executed yet? What do you plan to do if node_modules folder is missing?

@piotrtomiak
Copy link

Agreed with @micaelgallego: package.json seems like a very good place to look for the stuff and have a failsafe with nature if not found (Convert as Angular2 and add nature).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants