Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case test_phuzzer.py raises exceptions on import #10

Open
twizmwazin opened this issue Feb 10, 2021 · 3 comments · May be fixed by #17
Open

Test case test_phuzzer.py raises exceptions on import #10

twizmwazin opened this issue Feb 10, 2021 · 3 comments · May be fixed by #17
Assignees
@twizmwazin
Labels
bug Something isn't working

Comments

@twizmwazin
Copy link
Member

phuzzer/tests/test_fuzzer.py

Line 17 in cf9feab

raise ValueError("Error cannot find binaries intallation path")

In certain cases, this will be raised causing the module not to import, which causes a ModuleLoadException failure in the CI pipeline.

My proposed solution is to replace the checks in-test with some system to determine which phuzzer backends are available, and then to refactor the tests to use@unittest.skipUnless to automatically skip tests not able to be run with the current configuration.
@twizmwazin twizmwazin added the bug Something isn't working label Feb 10, 2021
@github-actions
Copy link

This issue has been marked as stale because it has no recent activity. Please comment or add the pinned tag to prevent this issue from being closed.

@github-actions github-actions bot added the stale label May 18, 2022
@twizmwazin twizmwazin self-assigned this May 18, 2022
@twizmwazin twizmwazin removed the stale label May 18, 2022
@twizmwazin twizmwazin linked a pull request May 20, 2022 that will close this issue
Open
@github-actions
Copy link

This issue has been marked as stale because it has no recent activity. Please comment or add the pinned tag to prevent this issue from being closed.

@github-actions github-actions bot added the stale label Jul 18, 2022
@twizmwazin twizmwazin removed the stale label Jul 18, 2022
@github-actions
Copy link

This issue has been marked as stale because it has no recent activity. Please comment or add the pinned tag to prevent this issue from being closed.

@github-actions github-actions bot added the stale label Sep 17, 2022
@twizmwazin twizmwazin removed the stale label Sep 19, 2022
@twizmwazin twizmwazin changed the title Test case test_phuzzzer.py raises exceptions on import Test case test_phuzzer.py raises exceptions on import Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twizmwazin twizmwazin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor test to use unittest angr/phuzzer
1 participant
@twizmwazin