-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dist should have source map, min and regular versions #46
Comments
👍 |
I just tested the minified version. You webpack with redux but not the minified version of redux. This will always cause the following error message to appear:
Adding this to the webpack config will solve the issue: config.resolve.alias = {
redux: 'redux/dist/redux.min.js'
}; Not quite sure if you can specify this via webpack's CLI. |
Is there a plan to fix this error? Currently, the minified build in |
Hi, please see #140 . |
Thanks, I appreciate your efforts on this library. If I had the time, I'd step up and volunteer right away :( It's not a pretty solution, but I was able to resolve this by patching
Then, in my config block that sets up ng-redux, I put this code:
I'm working on an older project with no module loader/bundler, so there's no possibility of using webpack/browserify plugins to solve this issue. If anyone has a better solution, I'm all ears. |
Just kidding, that didn't work. Apparently the minification check runs before my ng-redux config. I don't want to overwrite the "process" variable by putting my config code before ng-redux. I also don't want to patch I'm going to leave it as-is and just live with the error message (and supposed slowness), unless someone can suggest a good solution. |
I just installed ng-redux via Bower. I see a
ng-redux.js
file in thedist
folder, and I thought "there should be a minified version". Then I opened the file, to see it is actually minified...So, I suggest:
ng-redux.min.js
to follow common practices;The text was updated successfully, but these errors were encountered: