Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Redux DevTools extension global variable #56

Closed
smithad15 opened this issue Dec 5, 2018 · 5 comments
Closed

Update Redux DevTools extension global variable #56

smithad15 opened this issue Dec 5, 2018 · 5 comments
Labels
foundational Maintenance, tooling, etc. good first issue Good for newcomers pkg: store Related to the store package

Comments

@smithad15
Copy link
Member

window.devToolsExtension is deprecated in favor of window.REDUX_DEVTOOLS_EXTENSION, and will be removed in next version of Redux DevTools:
https://github.com/zalmoxisus/redux-devtools-extension#usage

@smithad15 smithad15 added good first issue Good for newcomers pkg: store Related to the store package foundational Maintenance, tooling, etc. labels Dec 5, 2018
@wtho
Copy link
Contributor

wtho commented Jan 4, 2019

Solved by #58

@fvilers
Copy link

fvilers commented Jan 28, 2019

Could you release a 9.0.1 version with this fix?

@MaKCbIMKo
Copy link
Contributor

Just playing with a release 10.0.0 and found interesting thing: redux-devtools-extension added as a devDependency, but it's required as a dependency. And it makes my project to have this dependency as well.

I've created an issue to track that (#84).

@wtho
Copy link
Contributor

wtho commented May 10, 2019

but it's required as a dependency

Can you elaborate on that? I think it's only added as a DevDependency.

What is the exact issue? Do you mind it being installed in your project?


Edit:

Actually it should not affect our Angular bundle size, as we only import a type definition of redux-devtools-extension (which is stripped away by tsc on transpilation).

To be sure about this and inspect the size taken in your bundle by a package you can use ng build --prod --stats-json combined with webpack-bundle-analyzer.

@MaKCbIMKo
Copy link
Contributor

Probably, I was not clear enough with the case I have.

You're right that when you build the package it doesn't included into bundle.

But it still required by DevToolsExtension (dev-tools.ts file imports type definition). And in runtime you will have an error, because this import can't be resolved.

I don't mind to have redux-devtools-extension as DevDependency in my project. But if I build my project - I won't be able to run my project on other environments due to missing imports/references...

Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
foundational Maintenance, tooling, etc. good first issue Good for newcomers pkg: store Related to the store package
Development

No branches or pull requests

4 participants