Angular v8 support #90

asvishnyakov · 2019-06-24T02:27:28Z

This is a...

feature request
bug report
usage question

What toolchain are you using for transpilation/bundling?

Environment

NodeJS Version: 10.16
Typescript Version: 3.4
Angular Version: 8
@angular-redux/store version: 10
@angular/cli version: (if applicable)
OS: Windows

Additional Notes:

Should we wait support of angular v8 from angular-redux or it's safe to use it as is with angular v8? Have you any plans to upgrade?

The text was updated successfully, but these errors were encountered:

smithad15 · 2019-07-07T22:40:37Z

There will definitely be an upgrade, however major version changes of Angular don't usually produce too many issues with using the library. Please do let us know if you see anything breaking in v8

esfandiar · 2019-07-09T17:59:48Z

We recently upgraded to Angular 8 and angular-redux v10 works fine with Angular 8, and we didn't have to change anything. The only annoyance is that yarn (npm would do it too I guess) throws a warning that angular-redux expects Angular 7 not 8. It would be nice if package.json was updated to support both.

smithad15 · 2019-07-09T18:53:44Z

That was my theory, but thank you for confirming. Feel free to utilize v10 with Angular 8. I will do a version bump at some point to remove the dependency warning, but that will require a major release and I want to see if I can get some more work in before I do so.

JackSchaible · 2019-07-09T22:25:08Z

I'm getting an error after upgrading to Angular 8 (from 7):
Property '[Symbol.observable]' is missing in type 'NgRedux<RootState>' but required in type 'ObservableStore<RootState>'.

Not sure if I need to update another package (maybe the redux node_module itself?). If it can help, my package.json has these dependencies:

"dependencies": {
"@angular-redux/form": "^10.0.0",
"@angular-redux/store": "^10.0.0",
"@angular/animations": "^8.1.0",
"@angular/cdk": "^8.0.2",
"@angular/common": "^8.1.0",
"@angular/compiler": "^8.1.0",
"@angular/core": "^8.1.0",
"@angular/forms": "^8.1.0",
"@angular/material": "^8.0.2",
"@angular/platform-browser": "^8.1.0",
"@angular/platform-browser-dynamic": "^8.1.0",
"@angular/router": "^8.1.0",
"@ngrx/store-devtools": "^8.0.1",
"core-js": "^3.1.4",
"hammerjs": "^2.0.8",
"ng-click-outside": "^4.0.0",
"npm": "^6.10.0",
"redux": "^4.0.3",
"redux-devtools-extension": "^2.13.8",
"rxjs": "~6.5.2",
"ts-md5": "^1.2.4",
"zone.js": "~0.9.1"
},
"devDependencies": {
"@angular-devkit/build-angular": "~0.801.0",
"@angular/cli": "^8.1.0",
"@angular/compiler-cli": "^8.1.0",
"@angular/language-service": "^8.1.0",
"@types/node": "~12.6.1",
"codelyzer": "^5.0.1",
"protractor": "~5.4.2",
"ts-node": "~8.3.0",
"tslint": "~5.18.0",
"typescript": "^3.4.5"
}

JackSchaible · 2019-07-09T22:35:02Z

I'm getting an error after upgrading to Angular 8 (from 7):
Property '[Symbol.observable]' is missing in type 'NgRedux<RootState>' but required in type 'ObservableStore<RootState>'.

Not sure if I need to update another package (maybe the redux node_module itself?). If it can help, my package.json has these dependencies:

"dependencies": {
"@angular-redux/form": "^10.0.0",
"@angular-redux/store": "^10.0.0",
"@angular/animations": "^8.1.0",
"@angular/cdk": "^8.0.2",
"@angular/common": "^8.1.0",
"@angular/compiler": "^8.1.0",
"@angular/core": "^8.1.0",
"@angular/forms": "^8.1.0",
"@angular/material": "^8.0.2",
"@angular/platform-browser": "^8.1.0",
"@angular/platform-browser-dynamic": "^8.1.0",
"@angular/router": "^8.1.0",
"@ngrx/store-devtools": "^8.0.1",
"core-js": "^3.1.4",
"hammerjs": "^2.0.8",
"ng-click-outside": "^4.0.0",
"npm": "^6.10.0",
"redux": "^4.0.3",
"redux-devtools-extension": "^2.13.8",
"rxjs": "~6.5.2",
"ts-md5": "^1.2.4",
"zone.js": "~0.9.1"
},
"devDependencies": {
"@angular-devkit/build-angular": "~0.801.0",
"@angular/cli": "^8.1.0",
"@angular/compiler-cli": "^8.1.0",
"@angular/language-service": "^8.1.0",
"@types/node": "~12.6.1",
"codelyzer": "^5.0.1",
"protractor": "~5.4.2",
"ts-node": "~8.3.0",
"tslint": "~5.18.0",
"typescript": "^3.4.5"
}

Ok, found the issue. Apparently, [email protected] doesn't work. Installed 4.0.1, works fine. Hope this helps anyone who has the same issue.

asvishnyakov · 2019-07-12T22:45:31Z

@smithad15

but that will require a major release and I want to see if I can get some more work in before I do so.

Hah, it's what about I argued with my team few weeks ago. Why do we need to wait any additional changes? Why we can't just make yet another release even if it require minor or major version bump? Why it can't include only single simple fix? Chrome now have version 75 and there are no one worry about that.

Sieabah · 2019-07-21T21:15:15Z

Could it just be a patch release to change the package.json? I really don't want to wait just so I can get rid of some install warnings that I can't tell which ones are real warnings anymore. You've had 2 months since Angular 8 has been released to fix this?

ghost · 2019-07-27T12:09:07Z

Im getting the same error as @JackSchaible
will there be a fix ? or should I downgrade my Redux to 4.0.1 ?

This package was failing because of a transitive dependency on redux. See angular-redux/platform#90 (comment).

craigryan · 2019-07-29T13:38:33Z

Update It builds once I change redux from ^4.0.1 to just 4.0.1. I'll leave the following as is in case it helps anyone else.

"Ok, found the issue. Apparently, [email protected] doesn't work. Installed 4.0.1, works fine. Hope this helps anyone who has the same issue."

This didn't fix the problem. My versions are as follows (redux set from 4.0.4 back to 4.0.1, same error).

"@angular-redux/store": "^10.0.0", "redux": "^4.0.1", "redux-devtools-extension": "^2.13.8",

and I'm on Angular 8.1.3. The error with either redux version is

ERROR in node_modules/@angular-redux/store/components/ng-redux.d.ts:10:31 - error TS2420: Class 'NgRedux' incorrectly implements interface 'ObservableStore'.
Property '[Symbol.observable]' is missing in type 'NgRedux' but required in type 'ObservableStore'.

10 export declare abstract class NgRedux implements ObservableStore {

node_modules/redux/index.d.ts:247:3
247 [Symbol.observable()]: Observable<S>
[Symbol.observable] is declared here.

This package was failing because of a transitive dependency on redux. See angular-redux/platform#90 (comment).

HarelM · 2019-08-30T12:28:33Z

Any chance to update the dependency for angular? I'm using this version with angular 8 and it works as expected, I would like to avoid seeing the npm warnings...

asvishnyakov · 2019-08-30T19:30:36Z

I still expecting problems with redux-observable-decorator (@Epic) because of lacking support of es2015 mode in redux observable: redux-observable/redux-observable#644

because of that I was need to create a fork of redux-observable decorator (https://github.com/asvishnyakov/redux-observable-decorator-es6-compat) and use it together with redux-observable-es6-compat to have ability to use differential loading

Sieabah · 2019-09-26T21:53:55Z

@dalu I've just moved to using ngxs instead of relying on this directly.

HarelM · 2019-09-27T18:15:42Z

@dalu see my comment above...

kirillgroshkov · 2020-02-15T22:02:42Z

any progress on this?

petebacondarwin mentioned this issue Jul 29, 2019

angular-redux/store angular/ngcc-validation#58

Closed

petebacondarwin added a commit to petebacondarwin/ngcc-validation that referenced this issue Jul 29, 2019

Fix redux dependency for angular-redux/store

1aa8f01

This package was failing because of a transitive dependency on redux. See angular-redux/platform#90 (comment).

petebacondarwin mentioned this issue Jul 29, 2019

Fix redux dependency for angular-redux/store angular/ngcc-validation#59

Merged

mgechev pushed a commit to angular/ngcc-validation that referenced this issue Jul 29, 2019

Fix redux dependency for angular-redux/store (#59)

6a784c6

This package was failing because of a transitive dependency on redux. See angular-redux/platform#90 (comment).

LukasKlement mentioned this issue Nov 5, 2019

angular-redux/store error with won't compile with rxjs 6.4.0/redux 4.0.4 #101

Open

2 tasks

asvishnyakov mentioned this issue Feb 26, 2020

Angular 9 support #111

Open

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Angular v8 support #90

Angular v8 support #90

asvishnyakov commented Jun 24, 2019

smithad15 commented Jul 7, 2019

esfandiar commented Jul 9, 2019 •

edited

Loading

smithad15 commented Jul 9, 2019

JackSchaible commented Jul 9, 2019 •

edited

Loading

JackSchaible commented Jul 9, 2019

asvishnyakov commented Jul 12, 2019 •

edited

Loading

Sieabah commented Jul 21, 2019

ghost commented Jul 27, 2019

craigryan commented Jul 29, 2019 •

edited

Loading

HarelM commented Aug 30, 2019

asvishnyakov commented Aug 30, 2019 •

edited

Loading

Sieabah commented Sep 26, 2019

HarelM commented Sep 27, 2019

kirillgroshkov commented Feb 15, 2020

Angular v8 support #90

Angular v8 support #90

Comments

asvishnyakov commented Jun 24, 2019

This is a...

What toolchain are you using for transpilation/bundling?

Environment

Additional Notes:

smithad15 commented Jul 7, 2019

esfandiar commented Jul 9, 2019 • edited Loading

smithad15 commented Jul 9, 2019

JackSchaible commented Jul 9, 2019 • edited Loading

JackSchaible commented Jul 9, 2019

asvishnyakov commented Jul 12, 2019 • edited Loading

Sieabah commented Jul 21, 2019

ghost commented Jul 27, 2019

craigryan commented Jul 29, 2019 • edited Loading

HarelM commented Aug 30, 2019

asvishnyakov commented Aug 30, 2019 • edited Loading

Sieabah commented Sep 26, 2019

HarelM commented Sep 27, 2019

kirillgroshkov commented Feb 15, 2020

esfandiar commented Jul 9, 2019 •

edited

Loading

JackSchaible commented Jul 9, 2019 •

edited

Loading

asvishnyakov commented Jul 12, 2019 •

edited

Loading

craigryan commented Jul 29, 2019 •

edited

Loading

asvishnyakov commented Aug 30, 2019 •

edited

Loading