Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When clicked, October events show no details #340

Closed
jdegand opened this issue Jul 20, 2024 · 3 comments
Closed

[Bug]: When clicked, October events show no details #340

jdegand opened this issue Jul 20, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@jdegand
Copy link
Contributor

jdegand commented Jul 20, 2024

Relevant scope

angular application

Description

october-events-bug

Maybe, there is a typo for the October events.

Do you want to contribute with a pull request?

No

@jdegand jdegand added the bug Something isn't working label Jul 20, 2024
@jdegand
Copy link
Contributor Author

jdegand commented Jul 20, 2024

I think this is related to the fact that the event ng-de spans multiple days.

@jdegand
Copy link
Contributor Author

jdegand commented Jul 20, 2024

The December 5, ng-be, event also doesn't show any details when clicked. Looking in community.json, the endDate field is not included in every model. I think the valibot schema doesn't have an optional endDate property, but changing the schema doesn't seem to be enough to fix the problem so maybe there is also a logic error.

Using event.url in event-section for trackBy could be problematic if an event is multiple dates? There really isn't anything unique in the event model.

@geromegrignon
Copy link
Contributor

fixed with #360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants