fix(core): make sure getAttribute is configurable

nartc · nartc · commit 48e64797c8d3 · 2025-02-01T17:46:52.000-06:00
diff --git a/libs/core/src/lib/renderer/state.ts b/libs/core/src/lib/renderer/state.ts
@@ -40,7 +40,7 @@ export function createNode(type: NgtRendererState[NgtRendererClassId.type], node
 	if (!('getAttribute' in rendererNode) || typeof rendererNode['getAttribute'] !== 'function') {
 		const nodeGetAttribute = (name: string) => rendererNode[name];
 		nodeGetAttribute['__ngt_renderer__'] = true;
-		Object.defineProperty(rendererNode, 'getAttribute', { value: nodeGetAttribute });
+		Object.defineProperty(rendererNode, 'getAttribute', { value: nodeGetAttribute, configurable: true });
 	}
 
 	return rendererNode;

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ export function createNode(type: NgtRendererState[NgtRendererClassId.type], node`
`40`	`40`	`if (!('getAttribute' in rendererNode) \|\| typeof rendererNode['getAttribute'] !== 'function') {`
`41`	`41`	`const nodeGetAttribute = (name: string) => rendererNode[name];`
`42`	`42`	`nodeGetAttribute['__ngt_renderer__'] = true;`
`43`		`- Object.defineProperty(rendererNode, 'getAttribute', { value: nodeGetAttribute });`
	`43`	`+ Object.defineProperty(rendererNode, 'getAttribute', { value: nodeGetAttribute, configurable: true });`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`return rendererNode;`