You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am re-opening this as the recommended workaround (postinstall: ngcc --properties main) is causing previously-working tests to fail.
The tests that fail are for instance simple tests that a pipe from ngrx is correctly stopping on destroy$ subject emit. The tests have been checked carefully that the destroy$ subject is firing and the stream keeps emitting.
My guess is that there is some difference between the compiled code from the main target (which compiles to UMD) and the es2015 target.
I am not understanding why the recommended postinstall hook (ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points) would result in entryComponents being required and ViewEngine being used for tests.
I am working on a repro which I will add here in a while.
I am re-opening this as the recommended workaround (
postinstall: ngcc --properties main
) is causing previously-working tests to fail.The tests that fail are for instance simple tests that a pipe from ngrx is correctly stopping on destroy$ subject emit. The tests have been checked carefully that the destroy$ subject is firing and the stream keeps emitting.
My guess is that there is some difference between the compiled code from the
main
target (which compiles to UMD) and the es2015 target.I am not understanding why the recommended postinstall hook (
ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points
) would result in entryComponents being required and ViewEngine being used for tests.I am working on a repro which I will add here in a while.
ref: #17110
We are having to declare entryComponents in tests after upgrading to A9; the documentation indicates this should not be necessary
The text was updated successfully, but these errors were encountered: