-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form-field): multiple pre/suffix displayed vertically + vertical alignment on Edge #14369
Conversation
…ildren when appearance is other than legacy. Also fixes a vertical alignment issue of mat-icon-button as pre/suffix in IE and Edge. Fixes angular#14311, angular#11650, angular#13094, angular#13322 & angular#13592
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Is there any time frame as to when this will be reviewed or labeled? |
Looks like this pull request was forgotten... I'm here because I'm affected by #14311 |
This breaks the layout for a large number of apps inside Google, and is therefore not feasible to merge. These issues should be fixed with the MDC-based form-field (currently still experimental) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Restores a consistent behavior for prefix and suffix with multiple children when appearance is other than legacy.
Also fixes a vertical alignment issue of mat-icon-button as pre/suffix in IE and Edge.
Fixes #14311, #11650, #13094, #13322 & #13592