Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-field): multiple pre/suffix displayed vertically + vertical alignment on Edge #14369

Closed
wants to merge 1 commit into from

Conversation

TFleury
Copy link

@TFleury TFleury commented Dec 3, 2018

Restores a consistent behavior for prefix and suffix with multiple children when appearance is other than legacy.

Also fixes a vertical alignment issue of mat-icon-button as pre/suffix in IE and Edge.
Fixes #14311, #11650, #13094, #13322 & #13592

…ildren when appearance is other than legacy.

Also fixes a vertical alignment issue of mat-icon-button as pre/suffix in IE and Edge.
Fixes angular#14311, angular#11650, angular#13094, angular#13322 & angular#13592
@TFleury TFleury requested a review from mmalerba as a code owner December 3, 2018 20:23
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Dec 3, 2018
@TFleury
Copy link
Author

TFleury commented Dec 3, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Dec 3, 2018
@dpalaganas
Copy link

Is there any time frame as to when this will be reviewed or labeled?

@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019
@BenoitMaisonny
Copy link

Looks like this pull request was forgotten... I'm here because I'm affected by #14311

@mmalerba
Copy link
Contributor

This breaks the layout for a large number of apps inside Google, and is therefore not feasible to merge. These issues should be fixed with the MDC-based form-field (currently still experimental)

@mmalerba mmalerba closed this Nov 22, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple mat-icon or mat-icon-button as prefix or suffix are displayed in columns
6 participants