docs(material/sidenav): Deprecated methods used in the responsive sidenav example #29317
+7,540
−8,773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enav example Fixes the bug in the documentation - Angular Material 'sidenav' component. Updated the ts file to use the CDK instead of using media queries Fixes angular#29266
lsamboretrorabbit
requested review from
crisbeto and
andrewseguin
and removed request for
a team
crisbeto
reviewed
Jun 25, 2024
src/components-examples/material/sidenav/sidenav-responsive/sidenav-responsive-example.ts
Outdated
Show resolved
Hide resolved
crisbeto
reviewed
Jun 26, 2024
src/components-examples/material/sidenav/sidenav-responsive/sidenav-responsive-example.html
Outdated
Show resolved
Hide resolved
src/components-examples/material/sidenav/sidenav-responsive/sidenav-responsive-example.html
Outdated
Show resolved
Hide resolved
src/components-examples/material/sidenav/sidenav-responsive/sidenav-responsive-example.html
Outdated
Show resolved
Hide resolved
…enav example Fixes the bug in the documentation - Angular Material 'sidenav' component. Updated the file 'sidenav-responsive-example' to use the CDK instead of using media queries Fixes angular#29266
|
@crisbeto thank you, i have made updates |
crisbeto
reviewed
Jun 28, 2024
src/components-examples/material/sidenav/sidenav-responsive/sidenav-responsive-example.ts
Outdated
Show resolved
Hide resolved
…enav example Fixes the bug in the documentation - Angular Material 'sidenav' component. Updated the file 'sidenav-responsive-example' to use the CDK instead of using media queries Fixes angular#29266
crisbeto
reviewed
Jul 2, 2024
| @@ -29,16 +36,27 @@ export class SidenavResponsiveExample implements OnDestroy { | |||
| cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.`, | |||
| ); | |||
|
|
|||
| private _mobileQueryListener: () => void; | |||
| mobileQuery: boolean; | |||
There was a problem hiding this comment.
I think that this and _breakpointSubscription aren't used anymore and can be removed.
…enav example Fixes the bug in the documentation - Angular Material 'sidenav' component. Updated the file 'sidenav-responsive-example' to use the CDK instead of using media queries Fixes angular#29266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug in the documentation - Angular Material 'sidenav' component.
Updated the file 'sidenav-responsive-example' to use the CDK instead of using media queries
Fixes #29266