Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs-bug(@angular/google-maps): map-info-window #29293

Closed
gstylli opened this issue Jun 20, 2024 · 2 comments
Closed

docs-bug(@angular/google-maps): map-info-window #29293

gstylli opened this issue Jun 20, 2024 · 2 comments
Labels
area: google-maps docs This issue is related to documentation good first issue This issue is a good place to start for first time contributors to the project P4 A relatively minor issue that is not relevant to core functions

Comments

@gstylli
Copy link

gstylli commented Jun 20, 2024

Documentation Feedback

There is an error in the map info window doc. It has #marker="marker" which should be #marker="mapAdvancedMarker" as below.

<google-map
height="400px"
width="750px"
[center]="center"
[zoom]="zoom"
(mapClick)="addMarker($event)">
@for (position of markerPositions; track position) {
<map-advanced-marker
#marker="mapAdvancedMarker"
[position]="position"
(mapClick)="openInfoWindow(marker)" />
}
Info Window content

Affected documentation page

https://github.com/angular/components/blob/main/src/google-maps/map-info-window/README.md

@gstylli gstylli added docs This issue is related to documentation needs triage This issue needs to be triaged by the team labels Jun 20, 2024
@crisbeto crisbeto removed their assignment Jun 25, 2024
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions good first issue This issue is a good place to start for first time contributors to the project area: google-maps and removed needs triage This issue needs to be triaged by the team labels Jun 25, 2024
@crisbeto
Copy link
Member

crisbeto commented Jul 5, 2024

Fixed in #29343.

@crisbeto crisbeto closed this as completed Jul 5, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: google-maps docs This issue is related to documentation good first issue This issue is a good place to start for first time contributors to the project P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

No branches or pull requests

2 participants