Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(MatListItem): Activated matListItemTitle color not changed when activated #29313

Closed
1 task
blogcraft opened this issue Jun 25, 2024 · 3 comments
Closed
1 task
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@blogcraft
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

The text of the activated MatListItem Should change color as it shows both in Angular Material and Material Design pages (m3)
image
image
image

But When Applied, Active only changes de button background.
image

<mat-list-item
  routerLink="{{ item().routerLink }}"
  routerLinkActive
  #rla="routerLinkActive"
  [activated]="rla.isActive">
  <span matListItemTitle>{{ item().descripcion }}</span>
</mat-list-item>

Reproduction

StackBlitz link: I don't know hot make stackblitz to run in 18..0.5

Expected Behavior

image
image
image

Actual Behavior

image

Environment

  • Angular: 18.0.5
  • CDK/Material: 18.0.5
  • Browser(s): Edge / Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
@blogcraft blogcraft added the needs triage This issue needs to be triaged by the team label Jun 25, 2024
@blogcraft
Copy link
Author

I changed the theme color pallete to other colors, and the activated background is still blue for some reason.

sims that --mat-list-active-indicator-color wont adapt to the theme and --mdc-list-list-item-label-text-color won't set to an activated color.

@andrewseguin
Copy link
Contributor

The color should be the system token md.sys.color.on-secondary-container according to https://m3.material.io/components/navigation-drawer/specs

This matches secondary 10 in your theme palettem, which is essentially white/black with a tiny bit of color to it. We made the color change more pronounced on the docs site, which doesn't actually match M3 but we think it looks better =P

@andrewseguin andrewseguin added needs: clarification The issue does not contain enough information for the team to determine if it is a real bug P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Jun 27, 2024
@mmalerba mmalerba removed the needs: clarification The issue does not contain enough information for the team to determine if it is a real bug label Aug 6, 2024
@mmalerba mmalerba closed this as completed Aug 6, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

3 participants