fix(material/chips): navigate between rows on up/down arrow #29364
+87
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the up/down arrows behave in the same way as left/right, however that's incorrect based on [the reference implementation](https://www.w3.org/WAI/ARIA/apg/patterns/grid/examples/layout-grids/#ex2_label) which shows them navigating between the rows. These changes update the logic in the chip grid so that it matches the expected behavior. Fixes angular#29359.
crisbeto
added
G
crisbeto
requested review from
mmalerba and
andrewseguin
and removed request for
a team
andrewseguin
added
the
dev-app preview
|
Deployed dev-app for 528fae4 to: https://ng-dev-previews-comp--pr-angular-components-29364-dev-t5zbi197.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Weird that UP/DOWN goes through the remove buttons if those are focused, but I see that's what the reference does |
andrewseguin
approved these changes
Jul 3, 2024
crisbeto
added a commit
that referenced
this pull request
Jul 3, 2024
Currently the up/down arrows behave in the same way as left/right, however that's incorrect based on [the reference implementation](https://www.w3.org/WAI/ARIA/apg/patterns/grid/examples/layout-grids/#ex2_label) which shows them navigating between the rows. These changes update the logic in the chip grid so that it matches the expected behavior. Fixes #29359. (cherry picked from commit 0519174)
crisbeto
added a commit
that referenced
this pull request
Jul 3, 2024
Currently the up/down arrows behave in the same way as left/right, however that's incorrect based on [the reference implementation](https://www.w3.org/WAI/ARIA/apg/patterns/grid/examples/layout-grids/#ex2_label) which shows them navigating between the rows. These changes update the logic in the chip grid so that it matches the expected behavior. Fixes #29359. (cherry picked from commit 0519174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the up/down arrows behave in the same way as left/right, however that's incorrect based on the reference implementation which shows them navigating between the rows.
These changes update the logic in the chip grid so that it matches the expected behavior.
Fixes #29359.