Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DatePicker): Add DateTime support to DatePicker OR new DateTimePicker Component #30023

Open
reminisc3 opened this issue Nov 14, 2024 · 5 comments
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@reminisc3
Copy link

Feature Description

Greetings,

I wanted to propose a new feature for the existing DatePicker OR to create a new extended component for "DateTimePicker".

I think the popular implementation for this is currently here:
https://github.com/h2qutc/angular-material-components/tree/master/projects/datetime-picker

However, the project has not been maintained and is only supported for <= Angular 16.

The request itself is straightforward, add "Time" support so that the user can select the Hour, Minutes, Seconds in addition to the date.

Use Case

Many applications have the requirement of the user selecting the full DateTime (Date, Hours, Mins, Secs) vs. just selecting only a basic date.

@reminisc3 reminisc3 added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Nov 14, 2024
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Nov 15, 2024
@alimirdeveloper
Copy link

alimirdeveloper commented Nov 23, 2024

i created for my own project in this way

maybe it can work for others
the date adapter is moment you can change it by your needs
ng-material-datetime-georgian

@i3ene
Copy link

i3ene commented Nov 27, 2024

I support this feature request! Especially not only a combined "Date" and "Time" picker, but also a "Range" picker version of this. This would reduce the headache to manually create such an input or to rely on other package implementations for this.

@reminisc3
Copy link
Author

Some updates on this topic -

  1. Angular 19 has introduced a new TimePicker component. However, the UX and integration with DatePicker seems a little suspect. The integration example relies on displaying two separate inputs for Date and Time which IMO will look odd on a form with other fields. I still think it's worth considering having an official component which implements both in a single form input/control.

https://material.angular.io/components/timepicker/overview#integration-with-matdatepicker

  1. The DateTimePicker implemented by h2qutc will no longer compile for Angular 19. It's broken as of now.

However, the author claims to be adding support for newer Angular Material versions soon:
h2qutc/angular-material-components#405

I support this feature request! Especially not only a combined "Date" and "Time" picker, but also a "Range" picker version of this. This would reduce the headache to manually create such an input or to rely on other package implementations for this.

100% agreed here. Having an official component supported by the official project would cut down on relying on depending on these 3rd party deps. I'm by no means diminishing the efforts of these 3rd party package authors - but it makes upgrading impossible unless you are willing try to find a suitable fork or do the work yourself.

@oxycoder
Copy link

Add time range picker to daterange picker would be nice feature that material still missing

Maybe allow user to
Image

@Narsun
Copy link

Narsun commented Dec 24, 2024

Agree with everything above. I am waiting for this "feature" for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

6 participants