Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdriver-manager should download Chromium's latest versions released and download the lowest value for ChromeDriver #410

Open
cnishina opened this issue Aug 12, 2019 · 6 comments

Comments

@cnishina
Copy link
Member

This should download the latest stable version that should match up with Chrome. At least that is the assumption

@cnishina
Copy link
Member Author

Should parse for channel for stable.

	}, {
		"branch_commit": "f5a1ee45b812b96c33344099823899840b77b2e0",
		"branch_base_position": "665002",
		"skia_commit": "f13f8690bede09ca97071e9786d68bc0758a24cc",
		"v8_version": "7.6.303.29",
		"previous_version": "76.0.3809.87",
		"v8_commit": "5bec950c6647873c777f55f1b95ed7ae5d7def73",
		"true_branch": "3809",
		"previous_reldate": "07/30/19",
		"branch_base_commit": "d82dec1a818f378c464ba307ddd9c92133eac355",
		"version": "76.0.3809.100",
		"current_reldate": "08/06/19",
		"current_version": "76.0.3809.100",
		"os": "win",
		"channel": "stable",
		"chromium_commit": "f5a1ee45b812b96c33344099823899840b77b2e0"
	}]

@cnishina
Copy link
Member Author

cnishina commented Aug 12, 2019

From there it looks like we could hit:

https://chromedriver.storage.googleapis.com/LATEST_RELEASE_76

Response: 76.0.3809.68

Or LATEST_RELEASE_ major value and get the version number. This would make life easier.

(Note, this might have not existed back when this was first implemented but I'm glad it exists. Also this will allow me to delete extra code. Yay!)

@cnishina
Copy link
Member Author

@cnishina cnishina added the P0 label Aug 13, 2019
@cnishina
Copy link
Member Author

Hrmm.... I have duplicate bugs. Going to keep this one open since it relates to the issue. Previous bug is #280

@IgorSasovets
Copy link

IgorSasovets commented Oct 23, 2019

Hi, @cnishina ! What if the webdriver-manager hit https://chromedriver.storage.googleapis.com/LATEST_RELEASE to get the latest chromedriver version? I faced with the chromedriver update issue when updated my Chrome browser version to the latest one (78.0.3904.70 at the moment of writing this comment) and protractor refused to start new driver instance because maximum version that webdriver-manager downloads is 76 and it doesn't work with the latest Chrome. Do you have any plan to fix this issue? Please let me know if you need any assistance or help with this. I have been using protractor for years and really like this project.

Sincerely,
Ihor

@IgorSasovets
Copy link

@cnishina , please take a look at this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants