Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get loader to work properly #1

Open
andycorm opened this issue Jan 20, 2015 · 1 comment
Open

Can't get loader to work properly #1

andycorm opened this issue Jan 20, 2015 · 1 comment

Comments

@andycorm
Copy link

I tried to get this to work, but didn't have any luck =(

For starters, the sample code to include this library as a dependency doesn't seem to work

(i.e.)

angular.module('your-app-name', [
  'angular-spinner'
]);

I kept getting errors in my console until I changed the dependency name to 'angularSpinner'.

Even after doing that, despite adding:

  <div spinner="">
      <img src="https://apps.dashplatform.com/dash/share/images/ajax_loading_spinner.gif" />
    </div>

The loader shows, but won't ever go away even after the content is all loaded. Did I do something wrong? I am using the delayed angular bootstrap call,

angular.bootstrap(document.getElementById('appRoot'), ['myApp']);

not sure if this is a problem or not. It didn't stop the popular angular-loading-bar plugin from working (but I'd much rather have a spinner than a fixed bar at the top of the page.)

Any help would be great! Thanks!

@andycorm
Copy link
Author

Nevermind.... sort of...

Apparently if you try to install this package via bower using the package name 'angular-spinner', it will actually install this repo here: https://github.com/urish/angular-spinner which has an identical name. I had accidentally installed that one, and that's why I was getting into the trouble that I was. I was able to fix this by changing my bower.json file to look like this:

 "dependencies": {
        "angular-spinner": "https://github.com/angularifyjs/angular-spinner.git"
    }

Any chance you'd be able to update this repo so that it has a different name? (At least in the bower package listings.) It seems to work great, so it would be a shame for it to not get more attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant