Skip to content

Commit 80ce17c

Browse files
Use INumberBase<T>.CreateChecked on .NET 7+ (#1518)
Implementing change suggested in #1483 .
1 parent 8d4fa52 commit 80ce17c

File tree

128 files changed

+6581
-1646
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

128 files changed

+6581
-1646
lines changed

CodeGen/Generators/UnitsNetGen/NumberExtensionsGenerator.cs

+4-1
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,11 @@ public static class NumberTo{_quantityName}Extensions
4949
where T : notnull
5050
#if NET7_0_OR_GREATER
5151
, INumber<T>
52+
=> {_quantityName}.From{unit.PluralName}(double.CreateChecked(value));
53+
#else
54+
, IConvertible
55+
=> {_quantityName}.From{unit.PluralName}(value.ToDouble(null));
5256
#endif
53-
=> {_quantityName}.From{unit.PluralName}(Convert.ToDouble(value));
5457
");
5558
}
5659

UnitsNet.NumberExtensions.Tests/UnitsNet.NumberExtensions.Tests.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net8.0</TargetFramework>
4+
<TargetFrameworks>net48;net8.0</TargetFrameworks>
55
<RootNamespace>UnitsNet.NumberExtensions.Tests</RootNamespace>
66
<LangVersion>latest</LangVersion>
77
<Nullable>enable</Nullable>

UnitsNet.NumberExtensions/GeneratedCode/NumberToAbsorbedDoseOfIonizingRadiationExtensions.g.cs

+64-16
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet.NumberExtensions/GeneratedCode/NumberToAccelerationExtensions.g.cs

+56-14
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)