Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new unit conversion for mmol/kg #1402

Closed
Martian42 opened this issue Jul 3, 2024 · 2 comments · Fixed by #1403
Closed

Add new unit conversion for mmol/kg #1402

Martian42 opened this issue Jul 3, 2024 · 2 comments · Fixed by #1403

Comments

@Martian42
Copy link
Contributor

Martian42 commented Jul 3, 2024

Is your feature request related to a problem? Please describe.
Add Molality unit prefix for millimole per kg (mmol/kg)

Describe the solution you'd like
Add SI unit conversion to the relevant existing Json files from new units descripted above.

Describe alternatives you've considered
The units are not covered by the existing UnitNet, but they are within existing Json files.

Additional context
Happy to write the code and raise a PR if you agree it's worth adding. They are units type already considered in Unitnet but simply adding to the range of conversion capability. All units above are commonly used world wide for a wide ranges of field.

@Martian42
Copy link
Contributor Author

Martian42 commented Jul 3, 2024

Please note μS/cm, mg/L is already in UnitNet. I can't change the name of the issue.

@angularsen I'm ready to push PR if you are ok with me adding prefix to Molality unit 😃

I don't have writing right at the moment.

@Martian42 Martian42 changed the title Add new unit conversion for mmol/kg, μS/cm, mg/L Add new unit conversion for mmol/kg Jul 4, 2024
@angularsen
Copy link
Owner

Sorry for late reply, I replied in #1403

angularsen pushed a commit that referenced this issue Jul 25, 2024
Add Milli prefix for MolePerKilogram to capture MillimolePerKilogram.
close #1402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants