From 770db8bad0646aa4295a7904bfde80388413ad5b Mon Sep 17 00:00:00 2001
From: Scott Burns <scott.s.burns@gmail.com>
Date: Mon, 11 Nov 2013 08:58:29 -0600
Subject: [PATCH] Raise exception when import_records fails

Fixes #20

Also adds:
- test that regular import works
- test that bad import throws RedcapError
---
 redcap/project.py    |  7 +++++--
 test/test_project.py | 16 ++++++++++++++++
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/redcap/project.py b/redcap/project.py
index 50665f18..e1e9ebaa 100644
--- a/redcap/project.py
+++ b/redcap/project.py
@@ -99,7 +99,7 @@ def export_fem(self, arms=None, format='obj', df_kwargs=None):
         arms: list
             Limit exported form event mappings to these arm numbers
         format: {'obj', 'csv', 'xml'} default obj
-            Return the form event mappings in native objects, 
+            Return the form event mappings in native objects,
             csv or xml, df will return a pandas.DataFrame
         df_kwargs: dict
             Passed to pandas.read_csv to control construction of
@@ -347,7 +347,10 @@ def import_records(self, to_import, overwrite='normal', format='json',
         pl['format'] = format
         pl['returnFormat'] = return_format
         pl['returnContent'] = return_content
-        return self._call_api(pl, 'imp_record')[0]
+        response = self._call_api(pl, 'imp_record')[0]
+        if 'error' in response:
+            raise RedcapError(str(response))
+        return response
 
     def export_file(self, record, field, event=None, return_format='json'):
         """ Export the contents of a file stored for a particular record
diff --git a/test/test_project.py b/test/test_project.py
index 4bcfcca8..7028d8f1 100644
--- a/test/test_project.py
+++ b/test/test_project.py
@@ -71,6 +71,22 @@ def test_long_export(self):
         for record in data:
             self.assertIsInstance(record, dict)
 
+    def test_import_records(self):
+        "Test record import"
+        data = self.reg_proj.export_records()
+        response = self.reg_proj.import_records(data)
+        self.assertIn('count', response)
+        self.assertNotIn('error', response)
+
+    def test_import_exception(self):
+        "Test record import throws RedcapError for bad import"
+        data = self.reg_proj.export_records()
+        data[0]['non_existent_key'] = 'foo'
+        with self.assertRaises(RedcapError) as cm:
+            self.reg_proj.import_records(data)
+        exc = cm.exception
+        self.assertIn('error', exc.args[0])
+
     def is_good_csv(self, csv_string):
         "Helper to test csv strings"
         return isinstance(csv_string, basestring)