Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser side error "animint is not defined" in global-variables test #141

Open
siddhesh195 opened this issue Jul 29, 2024 · 1 comment
Open

Comments

@siddhesh195
Copy link
Contributor

siddhesh195 commented Jul 29, 2024

@tdhock @Faye-yufan

I noticed an error on browser console during the execution of test renderer1-global-variables.

The error on browser console is as follows:

animint-htmltest/:20 Uncaught ReferenceError: animint is not defined
at animint-htmltest/:20:18

But the test still passes in R.

This is the only failing test case for the following commit I made for the html table task(#139 ):

0a78f92

I do not know whether this preexisting issue was the cause of the failure of my commit or not. But the test was passing for the previous commits I had made. The failure happened only in this commit where I add new functionality to add plots in the outer table even if the user wants fixed location for some plots and not for the others.

The same error is occurring even for chromote testing branch ( #126 ) as well. So I think it is preexisting issue in the main branch.

@tdhock
Copy link
Collaborator

tdhock commented Jul 29, 2024

I'm not sure about "Uncaught ReferenceError: animint is not defined"

but the test failure " ── Failure ('test-renderer1-global-variables.R:37:3'): animint.js only defines 1 object, called animint " in https://github.com/animint/animint2/actions/runs/10147526896/job/28058108659?pr=139 means that your new JS code is defining some global variables other than animint.
This test makes sure that we only define animint, and no other global variables, in JS code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants