added guided tour #164
added guided tour #164
Conversation
|
Closes #150 TDH: this comment does not work because the "Closes" comments must be in the first comment of the PR |
inst/htmljs/animint.js
Outdated
| element: "#" + id, | ||
| popover: { | ||
| title: geom.charAt(0).toUpperCase() + geom.slice(1), | ||
| description: `${helpText} Data are shown for the current selection of: ${showSelected}. Click to change selection of: ${clickSelects}.` |
There was a problem hiding this comment.
this looks like a good first step thanks!
when showSelected is an array ['var1','var2'], does this work?
also it could be missing or empty array [] (same for clickSelects, and help)
so in that case we would want to omit each missing part altogether.
inst/htmljs/animint.js
Outdated
| @@ -185,6 +185,24 @@ var animint = function (to_select, json_file) { | |||
|
|
|||
| var add_geom = function (g_name, g_info) { | |||
| // Determine if data will be an object or an array. | |||
| // added geom properties in steps array | |||
| var geom = g_info.geom; | |||
| var id = "plot_" + geom + "Plot"; | |||
There was a problem hiding this comment.
I'm not sure this selection based on id is correct. can you please use a selection based on g_info.classed?
see classes of <g> elements below
There was a problem hiding this comment.
if i use g_info.classed then it shows unexpected behaviors
There was a problem hiding this comment.
this is good! what is unexpected?
There was a problem hiding this comment.
For Geom2_vline_vlinePlot please
- please change "Geom2_vline_vlinePlot" to the value of
g_info.classed - remove "Data are shown for the current selection of ." no text like this should be shown if there are no showSelected variables.
- remove "Click to change selection of: ." no text like this should be shown if there is no clickSelects variable.
inst/htmljs/index.html
Outdated
| @@ -12,6 +12,8 @@ | |||
| <script type="text/javascript" src="vendor/jquery-1.11.3.min.js"></script> | |||
| <script type="text/javascript" src="vendor/selectize.min.js"></script> | |||
| <link rel="stylesheet" type="text/css" href="vendor/selectize.css" /> | |||
| <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/driver.js.iife.js"></script> | |||
There was a problem hiding this comment.
can you please copy these to inst/htmljs/vendor? and then use relative links here? (as with jquery etc above)
this approach is more stable (all files hosted on same server, don't need to rely on external cdn)
inst/htmljs/animint.js
Outdated
|
|
||
| element.append("button") | ||
| .text("Start Tour") | ||
|
|
There was a problem hiding this comment.
please undo addition of empty line in the middle of statements like this
inst/htmljs/animint.js
Outdated
| .text("Start Tour") | ||
|
|
||
| .on("click", function() { | ||
| startTour(); |
There was a problem hiding this comment.
if this is the only place that startTour is called, I think it not worth adding the startTour function. can you please move the contents of startTour inside this anonymous function?
|
looks like a good start, thanks very much! |
updated html to use relative paths
added guided tour feature
Closes #150