Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we remove stats/positions from docs? #158

Open
tdhock opened this issue Oct 16, 2024 · 3 comments
Open

should we remove stats/positions from docs? #158

tdhock opened this issue Oct 16, 2024 · 3 comments

Comments

@tdhock
Copy link
Collaborator

tdhock commented Oct 16, 2024

in animint2 we don't really use stat_* nor position_* but they appear in the docs, https://animint.github.io/animint2/reference/geom_hex.html which may be confusing.

@ampurr
Copy link
Contributor

ampurr commented Oct 18, 2024

To clarify: Are you advocating for removing all stat_ and position_ functions, or are you advocating for removing them from the documentation but not from the animint2 package? :O

I agree that neither set of functions is really animint2's idiom (though ofc you would know better than me). They are occasionally helpful, though. Like, someone might call position_jitter() to limit overplotting.

@tdhock
Copy link
Collaborator Author

tdhock commented Oct 18, 2024

probably would be good to remove both, so we would not have to write docs like this which explain features to avoid https://rcdata.nau.edu/genomic-ml/animint2-manual/Ch07-limitations.html#stats

@ampurr
Copy link
Contributor

ampurr commented Oct 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants