Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Add jobs of pylint, docs, formatting in .travis.yml #505

Open
4 tasks done
bismitaguha opened this issue Mar 16, 2020 · 6 comments
Open
4 tasks done

Add jobs of pylint, docs, formatting in .travis.yml #505

bismitaguha opened this issue Mar 16, 2020 · 6 comments
Labels
Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner.

Comments

@bismitaguha
Copy link
Contributor

Description

As a contributor,
I need to make respective tests for each contribution,
so that I can ensure proper code-checks

Mocks

N/A

Acceptance Criteria

Update [Required]

  • .travis.yml

Enhancement to Update [Optional]

  • Travis CI tests

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

1.5 hours

@bismitaguha
Copy link
Contributor Author

@sammy1997 @isabelcosta I would like to work on this issue. Please add the respective labels and assign it to me.

@sammy1997
Copy link
Contributor

Can you explain a bit about the changes you want to make?

@bismitaguha
Copy link
Contributor Author

bismitaguha commented Mar 16, 2020

@sammy1997 I wish to add jobs for python testing. No jobs are currently added in the .travis.yml. Adding jobs of pylint, docs and formatting will check all the formatting and pylint errors in the code before the build. This will maintain the code quality and check linting of every PR.

@sammy1997
Copy link
Contributor

Ok. Seems valid. Approving this

@sammy1997 sammy1997 added Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Difficulty: EASY labels Mar 17, 2020
@sammy1997
Copy link
Contributor

Adding a Pylint might cause the build to fail though. Don't send a PR yet. We need to discuss whether we want that in travis or do we want to add codacy for separate linting checks like VMS. We already have a flake test

@bismitaguha
Copy link
Contributor Author

Codacy is a better option as its only purpose is checking code quality. Travis CI can be kept separate only for the build purpose. Flake test is a part of pytest. We can use the complete features of pytest, not staying just limited to flake test.
@sammy1997 What are your suggestions on this?

@mayburgos mayburgos added Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. and removed PR Blocked labels May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner.
Projects
None yet
Development

No branches or pull requests

3 participants