Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Refactor meetup/utils.py #655

Open
2 tasks done
SanketDG opened this issue Aug 19, 2020 · 8 comments
Open
2 tasks done

Refactor meetup/utils.py #655

SanketDG opened this issue Aug 19, 2020 · 8 comments
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. First Timers Only Good for newcomers. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Maintenance Repository maintenance.

Comments

@SanketDG
Copy link
Contributor

Description

A lot of code in meetup/utils.py can be refactored, especially the jwt auth exchange

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

3 hours

@SanketDG SanketDG added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Maintenance Repository maintenance. First Timers Only Good for newcomers. labels Aug 19, 2020
@PragatiVerma18
Copy link

@SanketDG Can I take this up?

@SanketDG
Copy link
Contributor Author

SanketDG commented Sep 5, 2020

@PragatiVerma18 Assigned!

@sakshi1499
Copy link

@PragatiVerma18 Hi Any updates?

@sakshi1499 sakshi1499 added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Oct 16, 2020
@tejaswini22199
Copy link

Hello @SanketDG can I take up the issue!

@sakshi1499
Copy link

Sure! Assigned you @tejaswini22199

@tejaswini22199
Copy link

@sakshi1499 I removed multiple instances of payload and added only one of them. Can you help me in figuring out why it is failing tests while I'm merging.

@sakshi1499
Copy link

There was some issue with the last PR merge maybe that is why. Also, Your PR hasn't followed the commit guidelines so there are failing tests. @tejaswini22199

@sankha555
Copy link

Hello @SanketDG @sakshi1499,
I took a look at the PR by @tejaswinii22199 and your comments in that. I understood that we need to create functions for creating tokens and intitialize those tokens at runtime calls. I would like to attempt solving this issue. Could you please assign it to me if it's still open for contribution? Thanks!

@tejaswini22199 tejaswini22199 removed their assignment Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. First Timers Only Good for newcomers. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Maintenance Repository maintenance.
Projects
None yet
Development

No branches or pull requests

5 participants