Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden API / add a LOT more unit tests #40

Open
iskra-anl opened this issue Apr 20, 2021 · 2 comments
Open

Harden API / add a LOT more unit tests #40

iskra-anl opened this issue Apr 20, 2021 · 2 comments
Milestone
Second release

Comments

@iskra-anl
Copy link
Contributor

In GitLab by @perarnau on Aug 13, 2019, 10:13

The unit tests need a good cleanup, to become quicker and more exhaustive. Things I've noticed:

  • bitmap tests are too slow, and not very smart (checking that every bit can be set is not really necessary)
  • dma and scratchs are missing corner cases: invalid arguments, destroy too early, cancels in the middle of operations
@iskra-anl iskra-anl added this to the Second release milestone Apr 20, 2021
@iskra-anl
Copy link
Contributor Author

In GitLab by @perarnau on Aug 13, 2019, 16:43

mentioned in merge request !74

@iskra-anl
Copy link
Contributor Author

In GitLab by @perarnau on Jan 28, 2020, 10:18

Additional comments:

  • a lot of the generic API is not tested against new layouts.
  • layout-pad-row-major not validated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Second release
Development

No branches or pull requests
1 participant
@iskra-anl